From: Liu Bo <bo.li.liu@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] Btrfs-progs: add three more valid checks for superblock
Date: Wed, 11 May 2016 16:06:16 -0700 [thread overview]
Message-ID: <20160511230616.GB32358@localhost.localdomain> (raw)
In-Reply-To: <20160511133629.GD29353@twin.jikos.cz>
On Wed, May 11, 2016 at 03:36:29PM +0200, David Sterba wrote:
> On Mon, May 02, 2016 at 11:18:54AM -0700, Liu Bo wrote:
> > This adds valid checks for super_total_bytes, super_bytes_used and
> > super_stripesize.
> >
> > Since these checks are made after superblock finishes checksum
> > checking, this also adds a notice of "superblock checksum match but..".
> >
> > This also replaces different kinds of printf with helper error() and
> > warning().
>
> "This patch also does something completely different" is a good sign for
> patch splitting. I'll do that now but please keep that in mind next
> time.
Ah thanks a lot for that, I'd think more about maintenance.
Thanks,
-liubo
next prev parent reply other threads:[~2016-05-11 23:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 18:18 [PATCH 1/3] Btrfs-progs: add validation checks for chunk loading Liu Bo
2016-05-02 18:18 ` [PATCH 2/3] Btrfs-progs: add three more valid checks for superblock Liu Bo
2016-05-11 13:36 ` David Sterba
2016-05-11 23:06 ` Liu Bo [this message]
2016-05-02 18:18 ` [PATCH 3/3] Btrfs-progs: add fuzz testing images Liu Bo
2016-05-10 15:46 ` [PATCH 1/3] Btrfs-progs: add validation checks for chunk loading David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511230616.GB32358@localhost.localdomain \
--to=bo.li.liu@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).