From: David Sterba <dsterba@suse.cz>
To: Nicholas D Steeves <nsteeves@gmail.com>
Cc: Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 0/1] btrfs-progs: Typo review of strings and comments
Date: Fri, 13 May 2016 10:26:17 +0200 [thread overview]
Message-ID: <20160513082617.GV29353@suse.cz> (raw)
In-Reply-To: <CAD=QJKhQHeL5JnA+X1=e2DPqHS5UXVyPsDgaGMoTM15CyyCpLQ@mail.gmail.com>
On Thu, May 12, 2016 at 04:56:46PM -0400, Nicholas D Steeves wrote:
> Thank you for reviewing this patch. Sorry for missing the context of
> the strtoull comment; I should have been able to infer that and am
> embarrassed that I failed to. Also, embarrassed because I think I've
> used it in some C++ code!
>
> I learned how to use git rebase and git reset today, and can submit a
> v2 patch diffed against master at your earliest convenience. My only
> remaining question is this:
No need to send v2, I fixed the issues (and usually do if they seem
easy).
> mkfs.c: printf:("Incompatible features: %s", features_buf)
> * Should this be left as "Imcompat features"?
Actually yes, it should be 'Incompat', patch updated.
prev parent reply other threads:[~2016-05-13 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 23:50 [PATCH 0/1] btrfs-progs: Typo review of strings and comments Nicholas D Steeves
2016-05-11 23:50 ` [PATCH 1/1] " Nicholas D Steeves
2016-05-12 11:29 ` [PATCH 0/1] btrfs-progs: " David Sterba
2016-05-12 20:56 ` Nicholas D Steeves
2016-05-13 8:26 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160513082617.GV29353@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nsteeves@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).