From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH 2/4] btrfs-progs: ctree: return earlier for btrfs_previous_item
Date: Tue, 17 May 2016 14:50:52 +0200 [thread overview]
Message-ID: <20160517125051.GL511@twin.jikos.cz> (raw)
In-Reply-To: <1463456878-17550-3-git-send-email-quwenruo@cn.fujitsu.com>
On Tue, May 17, 2016 at 11:47:56AM +0800, Qu Wenruo wrote:
> Btrfs_previous_item() has a parameter to specify minimal objectid to
> return.
>
> But surprisingly it doesn't use it at all.
> Although that's OK, but it would take years long for large tree, so
> return it earlier.
This makes it closer to the kernel implementation, but still not equal,
there are some more shortcuts. Can you please port them as well? This
patch is independent of the rest so I'd take it separatelly.
next prev parent reply other threads:[~2016-05-17 12:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 3:47 [PATCH 0/4] Add support to clear v1 free space cache for btrfs check Qu Wenruo
2016-05-17 3:47 ` [PATCH 1/4] btrfs-progs: corrupt-block: Add ability to corrupt free space cache file Qu Wenruo
2016-05-17 13:00 ` David Sterba
2016-05-17 13:02 ` David Sterba
2016-05-18 0:49 ` Qu Wenruo
2016-05-17 3:47 ` [PATCH 2/4] btrfs-progs: ctree: return earlier for btrfs_previous_item Qu Wenruo
2016-05-17 12:50 ` David Sterba [this message]
2016-05-18 0:40 ` Qu Wenruo
2016-05-17 3:47 ` [PATCH 3/4] btrfs-progs: fsck: Add support to clear free space cache Qu Wenruo
2016-05-17 3:53 ` [PATCH v1.1 " Qu Wenruo
2016-05-17 3:47 ` [PATCH 4/4] btrfs-progs: tests: add 020-bad-free-space-cache Qu Wenruo
2016-05-17 3:56 ` [PATCH 0/4] Add support to clear v1 free space cache for btrfs check Qu Wenruo
2016-05-17 18:12 ` Ivan P
2016-05-18 1:00 ` Qu Wenruo
2016-05-19 16:54 ` Ivan P
2016-05-20 0:44 ` Qu Wenruo
2016-05-22 17:44 ` Ivan P
2016-05-23 1:18 ` Qu Wenruo
2016-05-18 9:14 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517125051.GL511@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).