From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:14965 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750732AbcEYUWg (ORCPT ); Wed, 25 May 2016 16:22:36 -0400 Date: Wed, 25 May 2016 16:22:26 -0400 From: Chris Mason To: , Omar Sandoval , , Al Viro , , Omar Sandoval Subject: Re: [PATCH] Btrfs: fix ->iterate_shared() by upgrading i_rwsem for delayed nodes Message-ID: <20160525202226.djc7dk4uhzuleets@floor.thefacebook.com> References: <1e937bd41beebb68b1bf1201205059cb8f614dad.1463777299.git.osandov@fb.com> <20160525201129.GQ29147@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20160525201129.GQ29147@twin.jikos.cz> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Wed, May 25, 2016 at 10:11:29PM +0200, David Sterba wrote: > On Fri, May 20, 2016 at 01:50:33PM -0700, Omar Sandoval wrote: > > Commit fe742fd4f90f ("Revert "btrfs: switch to ->iterate_shared()"") > > backed out the conversion to ->iterate_shared() for Btrfs because the > > delayed inode handling in btrfs_real_readdir() is racy. However, we can > > still do readdir in parallel if there are no delayed nodes. > > So this is for current master (pre 4.7-rc1), I'll add an appropriate > merge point for to my for-next. I'll get this bashed on in a big stress.sh run, but it looks good to me. -chris