From: Adam Borowski <kilobyte@angband.pl>
To: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] btrfs,vfs: allow FILE_EXTENT_SAME on a file opened ro
Date: Fri, 27 May 2016 00:57:01 +0200 [thread overview]
Message-ID: <20160526225701.GA22924@angband.pl> (raw)
In-Reply-To: <1463715912-8005-1-git-send-email-kilobyte@angband.pl>
On Fri, May 20, 2016 at 05:45:12AM +0200, Adam Borowski wrote:
> (Only btrfs currently implements dedupe_file_range.)
>
> Instead of checking the mode of the file descriptor, let's check whether
> it could have been opened rw. This allows fixing failures when deduping
> a live system: anyone trying to exec a file currently being deduped gets
> ETXTBSY.
>
> Issuing this ioctl on a ro file was already allowed for root/cap.
> fs/read_write.c | 2 +-
I'm unsure whom to bother with this patch. I've sent it to -btrfs as it's
relevant only to btrfs (at least currently), but technically the file
changed belongs to vfs. Was CCing -fsdevel enough or should I
retarget/resend the patch?
Apologies for a newbish question.
Meow!
--
An imaginary friend squared is a real enemy.
next prev parent reply other threads:[~2016-05-26 22:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 3:45 [PATCH] btrfs,vfs: allow FILE_EXTENT_SAME on a file opened ro Adam Borowski
2016-05-26 22:57 ` Adam Borowski [this message]
2016-05-27 0:04 ` Mark Fasheh
2016-05-27 0:48 ` Adam Borowski
2016-05-28 1:59 ` Zygo Blaxell
2016-05-29 0:21 ` Adam Borowski
2016-05-29 0:56 ` Zygo Blaxell
2016-05-29 6:53 ` Andrei Borzenkov
2016-05-30 12:24 ` Adam Borowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526225701.GA22924@angband.pl \
--to=kilobyte@angband.pl \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).