From: Roman Mamedov <rm@romanrm.net>
To: Mark Fasheh <mfasheh@suse.de>
Cc: Qu Wenruo <quwenruo@cn.fujitsu.com>,
linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.cz>,
chris@suse.de, Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH v7 0/8] Inband dedupe for btrfs-progs
Date: Thu, 2 Jun 2016 10:16:34 +0500 [thread overview]
Message-ID: <20160602101634.55f9c1be@natsu> (raw)
In-Reply-To: <20160601213210.GK7633@wotan.suse.de>
[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]
On Wed, 1 Jun 2016 14:32:10 -0700
Mark Fasheh <mfasheh@suse.de> wrote:
> Can we please have seperate and obvious namespaces for in-band dedupe and
> out-of-band dedupe commands? I realize that there is no oob-dedupe
> funcationality in btrfs-progs today but I would like to avoid confusing
> users in the case that this code hits btrfs-progs.
>
> Specifically by this, I mean I'd like to see anything except 'dedupe' as the
> btrfs command, so a user who sees 'btrfs dedupe ....' is not confusing the
> two forms we have.
>
> I don't personally care what other name is used and of course it could have
> 'dedupe' in the name just not solely 'dedupe'. As a poor example, we could
> call it 'btrfs inband-dedupe ...'.
There might be no such code added ever -- but everyone will be stuck with
typing "inband-dedupe" instead of the simple and short "dedupe" forever
because of this "future precaution".
At least make that "dedupe-inband", so that the shorthand form of "dedupe"
also works for now, and only starts throwing a warning if any other subcommand
starting with "dedupe" is added.
--
With respect,
Roman
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-06-02 5:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 6:37 [PATCH v7 0/8] Inband dedupe for btrfs-progs Qu Wenruo
2016-04-01 6:37 ` [PATCH v7 1/8] btrfs-progs: Basic framework for dedupe command group Qu Wenruo
2016-04-01 6:37 ` [PATCH v7 2/8] btrfs-progs: dedupe: Add enable command " Qu Wenruo
2016-04-01 6:37 ` [PATCH v7 3/8] btrfs-progs: dedupe: Add disable support for inband dedupelication Qu Wenruo
2016-04-01 6:37 ` [PATCH v7 4/8] btrfs-progs: dedupe: Add status subcommand Qu Wenruo
2016-04-01 6:37 ` [PATCH v7 5/8] btrfs-progs: Add dedupe feature for mkfs and convert Qu Wenruo
2016-04-01 6:37 ` [PATCH v7 6/8] btrfs-progs: Add show-super support for new DEDUPE flag Qu Wenruo
2016-04-01 6:37 ` [PATCH v7 7/8] btrfs-progs: debug-tree: Add dedupe tree support Qu Wenruo
2016-04-01 6:37 ` [PATCH v7 8/8] btrfs-progs: property: add a dedupe property Qu Wenruo
2016-06-01 21:32 ` [PATCH v7 0/8] Inband dedupe for btrfs-progs Mark Fasheh
2016-06-02 1:07 ` Qu Wenruo
2016-06-02 5:16 ` Roman Mamedov [this message]
2016-06-15 12:56 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602101634.55f9c1be@natsu \
--to=rm@romanrm.net \
--cc=chris@suse.de \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=mfasheh@suse.de \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).