From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f173.google.com ([209.85.192.173]:32959 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751807AbcFQR7P (ORCPT ); Fri, 17 Jun 2016 13:59:15 -0400 Received: by mail-pf0-f173.google.com with SMTP id i123so29112372pfg.0 for ; Fri, 17 Jun 2016 10:59:15 -0700 (PDT) Date: Fri, 17 Jun 2016 10:59:08 -0700 From: Omar Sandoval To: Chris Mason , dsterba@suse.cz, linux-btrfs@vger.kernel.org, Al Viro , kernel-team@fb.com, Omar Sandoval Subject: Re: [PATCH] Btrfs: fix ->iterate_shared() by upgrading i_rwsem for delayed nodes Message-ID: <20160617175908.GD28716@vader.DHCP.thefacebook.com> References: <1e937bd41beebb68b1bf1201205059cb8f614dad.1463777299.git.osandov@fb.com> <20160525201129.GQ29147@twin.jikos.cz> <20160525202226.djc7dk4uhzuleets@floor.thefacebook.com> <20160617175554.GC28716@vader.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20160617175554.GC28716@vader.DHCP.thefacebook.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Fri, Jun 17, 2016 at 10:55:54AM -0700, Omar Sandoval wrote: > On Wed, May 25, 2016 at 04:22:26PM -0400, Chris Mason wrote: > > On Wed, May 25, 2016 at 10:11:29PM +0200, David Sterba wrote: > > > On Fri, May 20, 2016 at 01:50:33PM -0700, Omar Sandoval wrote: > > > > Commit fe742fd4f90f ("Revert "btrfs: switch to ->iterate_shared()"") > > > > backed out the conversion to ->iterate_shared() for Btrfs because the > > > > delayed inode handling in btrfs_real_readdir() is racy. However, we can > > > > still do readdir in parallel if there are no delayed nodes. > > > > > > So this is for current master (pre 4.7-rc1), I'll add an appropriate > > > merge point for to my for-next. > > > > I'll get this bashed on in a big stress.sh run, but it looks good to me. > > > > -chris > > > > Chris/Dave, what's the plan for this? Since it's getting late for 4.7, > should we just think harder for a proper solution for 4.8? > > -- > Omar Whoops, I hit "g" in Mutt one too many times and sent to a bogus recipient, ignore that guy. -- Omar