From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, chandan@linux.vnet.ibm.com
Subject: Re: [PATCH v11 00/13] Btrfs dedupe framework
Date: Tue, 21 Jun 2016 11:13:42 +0200 [thread overview]
Message-ID: <20160621091342.GS4915@suse.cz> (raw)
In-Reply-To: <91d6f331-14de-5d1b-b73e-c24c0bfe950e@cn.fujitsu.com>
On Tue, Jun 21, 2016 at 08:36:49AM +0800, Qu Wenruo wrote:
> > I'm looking how well does this patchset merges with the rest, so far
> > there are excpected conflicts with Chandan's subpage-blocksize
> > patchset. For the easy parts, we can add stub patches to extend
> > functions like cow_file_range with parameters that are added by the
> > other patch.
> >
> > Honestly I don't know which patchset to take first. As the
> > subpage-blockszie is in the core, there are no user visibility and
> > interface questions, but it must not cause any regressions.
> >
> > Dedupe is optional, not default, and we have to mainly make sure it does
> > not have any impact when turned off.
> >
> > So I see three possible ways:
> >
> > * merge subpage first, as it defines the API, adapt dedupe
>
> Personally, I'd like to merge subpage first.
>
> AFAIK, it's more important than dedupe.
> It affects whether a fs created in 64K page size environment can be
> mounted on a 4K page size system.
Yeah, but I'm now concerned about the way both will be integrated in the
development or preview branches, not really the functionality itself.
Now the conflicts are not trivial, so this takes extra time on my side
and I can't be sure about the result in the end if I put only minor
efforts to resolve the conflicts ("make it compile"). And I don't want
to do that too often.
As stated in past discussions, the features of this impact should spend
one development cycle in for-next, even if it's not ready for merge or
there are reviews going on.
The subpage patchset is now in a relatively good shape to start actual
testing, which already revealed some problems.
next prev parent reply other threads:[~2016-06-21 9:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 2:09 [PATCH v11 00/13] Btrfs dedupe framework Qu Wenruo
2016-06-15 2:09 ` [PATCH v11 01/13] btrfs: dedupe: Introduce dedupe framework and its header Qu Wenruo
2016-06-15 2:09 ` [PATCH v11 02/13] btrfs: dedupe: Introduce function to initialize dedupe info Qu Wenruo
2016-06-15 2:09 ` [PATCH v11 03/13] btrfs: dedupe: Introduce function to add hash into in-memory tree Qu Wenruo
2016-06-15 2:09 ` [PATCH v11 04/13] btrfs: dedupe: Introduce function to remove hash from " Qu Wenruo
2016-06-15 2:09 ` [PATCH v11 05/13] btrfs: delayed-ref: Add support for increasing data ref under spinlock Qu Wenruo
2016-06-15 2:09 ` [PATCH v11 06/13] btrfs: dedupe: Introduce function to search for an existing hash Qu Wenruo
2016-06-15 2:09 ` [PATCH v11 07/13] btrfs: dedupe: Implement btrfs_dedupe_calc_hash interface Qu Wenruo
2016-06-15 2:09 ` [PATCH v11 08/13] btrfs: ordered-extent: Add support for dedupe Qu Wenruo
2016-06-15 2:09 ` [PATCH v11 09/13] btrfs: dedupe: Inband in-memory only de-duplication implement Qu Wenruo
2016-06-15 2:09 ` [PATCH v11 10/13] btrfs: dedupe: Add ioctl for inband dedupelication Qu Wenruo
2016-06-15 2:09 ` [PATCH v11 11/13] btrfs: relocation: Enhance error handling to avoid BUG_ON Qu Wenruo
2016-06-15 2:10 ` [PATCH v11 12/13] btrfs: improve inode's outstanding_extents computation Qu Wenruo
2016-06-15 2:10 ` [PATCH v11 13/13] btrfs: dedupe: fix false ENOSPC Qu Wenruo
2016-06-15 3:11 ` kbuild test robot
2016-06-15 3:17 ` [PATCH v11.1 " Qu Wenruo
2016-06-15 3:26 ` [PATCH v11 " kbuild test robot
2016-06-20 16:03 ` [PATCH v11 00/13] Btrfs dedupe framework David Sterba
2016-06-21 0:36 ` Qu Wenruo
2016-06-21 9:13 ` David Sterba [this message]
2016-06-21 9:26 ` Qu Wenruo
2016-06-21 9:34 ` David Sterba
2016-06-21 16:55 ` Chandan Rajendra
2016-06-23 12:17 ` David Sterba
2016-06-24 2:50 ` Qu Wenruo
2016-06-24 4:34 ` Chandan Rajendra
2016-06-24 9:29 ` Chandan Rajendra
2016-06-25 1:22 ` Qu Wenruo
2016-06-25 5:45 ` Chandan Rajendra
2016-06-27 3:04 ` Qu Wenruo
2016-06-24 4:10 ` Chandan Rajendra
2016-06-22 1:48 ` Qu Wenruo
2016-06-24 6:54 ` Satoru Takeuchi
2016-06-24 8:30 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621091342.GS4915@suse.cz \
--to=dsterba@suse.cz \
--cc=chandan@linux.vnet.ibm.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).