From: Liu Bo <bo.li.liu@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix BUG_ON in btrfs_submit_compressed_write
Date: Thu, 23 Jun 2016 10:41:11 -0700 [thread overview]
Message-ID: <20160623174110.GB13924@localhost.localdomain> (raw)
In-Reply-To: <20160623090952.GV4915@twin.jikos.cz>
On Thu, Jun 23, 2016 at 11:09:52AM +0200, David Sterba wrote:
> On Wed, Jun 22, 2016 at 06:32:06PM -0700, Liu Bo wrote:
> > This is similar to btrfs_submit_compressed_read(), if we fail after
> > bio is allocated, then we can use bio_endio() and errors are saved
> > in bio->bi_error. But please note that we don't return errors to
> > its caller because the caller assumes it won't call endio to cleanup
> > on error.
>
> This sounds strange, where do we notice that some of the bios failed?
bio_endio()
-> end_compressed_bio_write()
-> end_compressed_writeback()
-> mapping_set_error(inode->i_mapping, -EIO);
Thanks,
-liubo
next prev parent reply other threads:[~2016-06-23 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 1:32 [PATCH] Btrfs: fix BUG_ON in btrfs_submit_compressed_write Liu Bo
2016-06-23 9:09 ` David Sterba
2016-06-23 17:41 ` Liu Bo [this message]
2016-07-08 14:47 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623174110.GB13924@localhost.localdomain \
--to=bo.li.liu@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).