* [PATCH] btrfs-progs: tests: 001-simple-unmounted: fix test failure due to bashism
@ 2016-06-24 23:47 Luis Henriques
2016-07-04 11:37 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Luis Henriques @ 2016-06-24 23:47 UTC (permalink / raw)
To: linux-btrfs; +Cc: David Sterba
The usage of 'source' is a bashism, and '.' should be used instead. This
is causing fuzz-tests/001-simple-unmounted to fail in systems where
/bin/sh isn't bash:
[TEST/fuzz] 001-simple-unmounted
./test.sh: 5: ./test.sh: source: not found
./test.sh: 7: ./test.sh: setup_root_helper: not found
./test.sh: 8: ./test.sh: check_prereq: not found
./test.sh: 18: ./test.sh: check_all_images: not found
Since most (all?) tests actually use /bin/bash, change this test to use
bash too.
Signed-off-by: Luis Henriques <henrix@camandro.org>
---
tests/fuzz-tests/001-simple-unmounted/test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/fuzz-tests/001-simple-unmounted/test.sh b/tests/fuzz-tests/001-simple-unmounted/test.sh
index bf01a3a45a96..98fe7b0ccb74 100755
--- a/tests/fuzz-tests/001-simple-unmounted/test.sh
+++ b/tests/fuzz-tests/001-simple-unmounted/test.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# iterate over all fuzzed images and run 'btrfs check'
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs-progs: tests: 001-simple-unmounted: fix test failure due to bashism
2016-06-24 23:47 [PATCH] btrfs-progs: tests: 001-simple-unmounted: fix test failure due to bashism Luis Henriques
@ 2016-07-04 11:37 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2016-07-04 11:37 UTC (permalink / raw)
To: Luis Henriques; +Cc: linux-btrfs, David Sterba
On Sat, Jun 25, 2016 at 12:47:29AM +0100, Luis Henriques wrote:
> The usage of 'source' is a bashism, and '.' should be used instead. This
> is causing fuzz-tests/001-simple-unmounted to fail in systems where
> /bin/sh isn't bash:
>
> [TEST/fuzz] 001-simple-unmounted
> ./test.sh: 5: ./test.sh: source: not found
> ./test.sh: 7: ./test.sh: setup_root_helper: not found
> ./test.sh: 8: ./test.sh: check_prereq: not found
> ./test.sh: 18: ./test.sh: check_all_images: not found
>
> Since most (all?) tests actually use /bin/bash, change this test to use
> bash too.
>
> Signed-off-by: Luis Henriques <henrix@camandro.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-04 11:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-24 23:47 [PATCH] btrfs-progs: tests: 001-simple-unmounted: fix test failure due to bashism Luis Henriques
2016-07-04 11:37 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).