From: Eryu Guan <eguan@redhat.com>
To: jeffm@suse.com
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/4] fstests: btrfs/124: test global metadata reservation reporting
Date: Mon, 27 Jun 2016 15:24:38 +0800 [thread overview]
Message-ID: <20160627072438.GR23649@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20160627071647.GP23649@eguan.usersys.redhat.com>
On Mon, Jun 27, 2016 at 03:16:47PM +0800, Eryu Guan wrote:
> On Fri, Jun 24, 2016 at 11:08:32AM -0400, jeffm@suse.com wrote:
> > From: Jeff Mahoney <jeffm@suse.com>
> >
[snip]
> > +
> > +# get standard environment, filters and checks
> > +. ./common/rc
> > +. ./common/filter.btrfs
> > +
> > +_supported_fs btrfs
> > +_supported_os Linux
> > +_require_scratch
> > +
> > +_scratch_mkfs > /dev/null 2>&1
> > +_scratch_mount
>
> There should be some kind of "_require_xxx" or something like that to
> _notrun if current running kernel doesn't have global metadata
> reservation report implemented.
Also need a _require_test_program call to make sure btrfs_ioctl_helper
is built and in src/ dir.
_require_test_program "btrfs_ioctl_helper"
Sorry, I missed it in first revlew.
Thanks,
Eryu
next prev parent reply other threads:[~2016-06-27 7:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 15:08 [PATCH 1/4] fstests: btrfs/048: extend _filter_btrfs_prop_error to handle additional errors jeffm
2016-06-24 15:08 ` [PATCH 2/4] fstests: btrfs/124: test global metadata reservation reporting jeffm
2016-06-27 7:16 ` Eryu Guan
2016-06-27 7:24 ` Eryu Guan [this message]
2016-06-24 15:08 ` [PATCH 3/4] fstests: btrfs/125: test sysfs exports of allocation and device membership info jeffm
2016-06-27 8:26 ` Eryu Guan
2016-06-24 15:08 ` [PATCH 4/4] fstests: btrfs/126,127,128: test feature ioctl and sysfs interfaces jeffm
2016-06-27 9:11 ` Eryu Guan
2016-06-27 4:24 ` [PATCH 1/4] fstests: btrfs/048: extend _filter_btrfs_prop_error to handle additional errors Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627072438.GR23649@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).