Re: [PATCH 1/2] remove mapping from balance_dirty_pages*()

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2431 bytes --]

Hi Josef,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.8-rc1 next-20160809]
[cannot apply to linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Josef-Bacik/Provide-accounting-for-dirty-metadata/20160810-031219
config: x86_64-randconfig-x019-201632 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/linkage.h:4:0,
                    from include/linux/kernel.h:6,
                    from mm/page-writeback.c:14:
   mm/page-writeback.c: In function 'balance_dirty_pages_ratelimited':
   mm/page-writeback.c:1873:6: error: implicit declaration of function 'bdi_cgwb_enabled' [-Werror=implicit-function-declaration]
     if (bdi_cgwb_enabled(bdi, sb))
         ^
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> mm/page-writeback.c:1873:2: note: in expansion of macro 'if'
     if (bdi_cgwb_enabled(bdi, sb))
     ^~
   cc1: some warnings being treated as errors

vim +/if +1873 mm/page-writeback.c

  1857	 *
  1858	 * On really big machines, get_writeback_state is expensive, so try to avoid
  1859	 * calling it too often (ratelimiting).  But once we're over the dirty memory
  1860	 * limit we decrease the ratelimiting by a lot, to prevent individual processes
  1861	 * from overshooting the limit by (ratelimit_pages) each.
  1862	 */
  1863	void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi,
  1864					     struct super_block *sb)
  1865	{
  1866		struct bdi_writeback *wb = NULL;
  1867		int ratelimit;
  1868		int *p;
  1869	
  1870		if (!bdi_cap_account_dirty(bdi))
  1871			return;
  1872	
> 1873		if (bdi_cgwb_enabled(bdi, sb))
  1874			wb = wb_get_create_current(bdi, GFP_KERNEL);
  1875		if (!wb)
  1876			wb = &bdi->wb;
  1877	
  1878		ratelimit = current->nr_dirtied_pause;
  1879		if (wb->dirty_exceeded)
  1880			ratelimit = min(ratelimit, 32 >> (PAGE_SHIFT - 10));
  1881	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 26211 bytes --]