From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:33764 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758289AbcH3MKK (ORCPT ); Tue, 30 Aug 2016 08:10:10 -0400 Date: Tue, 30 Aug 2016 14:08:50 +0200 From: David Sterba To: Wang Xiaoguang Cc: Qu Wenruo , linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs-progs: check: skip shared node or leaf check for low_memory mode Message-ID: <20160830120850.GD16983@suse.cz> Reply-To: dsterba@suse.cz References: <20160819095946.31917-1-wangxg.fnst@cn.fujitsu.com> <20160824124431.GQ16983@twin.jikos.cz> <57BE8261.4040308@cn.fujitsu.com> <20160829152035.GV16983@twin.jikos.cz> <0158e565-3bb8-01fb-362f-6d5d8ec4cf35@cn.fujitsu.com> <20160830113202.GB16983@suse.cz> <57C57191.1030909@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <57C57191.1030909@cn.fujitsu.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Tue, Aug 30, 2016 at 07:44:17PM +0800, Wang Xiaoguang wrote: > Hi, > > On 08/30/2016 07:32 PM, David Sterba wrote: > > On Tue, Aug 30, 2016 at 09:50:20AM +0800, Qu Wenruo wrote: > >>> Are they not? The low-memory patchset has been released in 4.7.1, the > >>> devel branch is always on top of master branch. I see both branches > >>> pushed to the public git repos so I don't see what you mean. > >> Unfortunately, the low memory mode is not fully merged into devel branch. > >> > >> Only the first part (extent and chunk tree) is merged. > >> > >> The second part(fs tree) is not merged yet. > >> > >> Patches like the following is not in either devel/master branch: > >> Lu Fengqi (13): > >> btrfs-progs: move btrfs_extref_hash() to hash.h > >> btrfs-progs: check: introduce function to find dir_item > >> btrfs-progs: check: introduce function to check inode_ref > >> btrfs-progs: check: introduce function to check inode_extref > >> btrfs-progs: check: introduce function to find inode_ref > >> btrfs-progs: check: introduce a function to check dir_item > >> btrfs-progs: check: introduce function to check file extent > >> btrfs-progs: check: introduce function to check inode item > >> btrfs-progs: check: introduce function to check fs root > >> btrfs-progs: check: introduce function to check root ref > >> btrfs-progs: check: introduce low_memory mode fs_tree check > >> btrfs-progs: check: fix the return value bug of cmd_check() > >> btrfs-progs: check: fix false warning for check_extent_item() > >> > >> So Wang found it confusing and unable to apply his patch to devel branch. > > He could have replied himself, I think the conversation would feel > > better when we can talk directly :) > Yes, I agree. I was on leave for a while this morning :) Doh, I may be confused by the names, I mean that I've never seen a mail from 'Lu Fengqi'.