From: David Sterba <dsterba@suse.cz>
To: jbacik@fb.com
Cc: linux-btrfs@vger.kernel.org, fdmanana@kernel.org,
Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
Subject: Re: [PATCH] btrfs: fix WARNING in btrfs_select_ref_head()
Date: Tue, 6 Sep 2016 19:34:27 +0200 [thread overview]
Message-ID: <20160906173427.GF16983@twin.jikos.cz> (raw)
In-Reply-To: <1466385532-6005-1-git-send-email-wangxg.fnst@cn.fujitsu.com>
Josef, can you please review this?
On Mon, Jun 20, 2016 at 09:18:52AM +0800, Wang Xiaoguang wrote:
> This issue was found when testing in-band dedupe enospc behaviour,
> sometimes run_one_delayed_ref() may fail for enospc reason, then
> __btrfs_run_delayed_refs（）will return, but forget to add num_heads_read
> back, which will trigger "WARN_ON(delayed_refs->num_heads_ready == 0)" in
> btrfs_select_ref_head().
>
> Signed-off-by: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
> ---
> fs/btrfs/extent-tree.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index 6146729..eeedff3 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -2665,7 +2665,10 @@ static noinline int __btrfs_run_delayed_refs(struct btrfs_trans_handle *trans,
>
> btrfs_free_delayed_extent_op(extent_op);
> if (ret) {
> + spin_lock(&delayed_refs->lock);
> locked_ref->processing = 0;
> + delayed_refs->num_heads_ready++;
> + spin_unlock(&delayed_refs->lock);
> btrfs_delayed_ref_unlock(locked_ref);
> btrfs_put_delayed_ref(ref);
> btrfs_debug(fs_info, "run_one_delayed_ref returned %d", ret);
> --
> 1.8.3.1
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-09-06 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 1:18 [PATCH] btrfs: fix WARNING in btrfs_select_ref_head() Wang Xiaoguang
2016-07-08 15:27 ` David Sterba
2016-09-06 17:34 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906173427.GF16983@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).