From: Liu Bo <bo.li.liu@oracle.com>
To: dsterba@suse.cz
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: kill BUG_ON in do_relocation
Date: Tue, 20 Sep 2016 10:59:59 -0700 [thread overview]
Message-ID: <20160920175959.GB3319@localhost.localdomain> (raw)
In-Reply-To: <20160920080343.GV16983@suse.cz>
On Tue, Sep 20, 2016 at 10:03:43AM +0200, David Sterba wrote:
> On Mon, Sep 19, 2016 at 04:11:44PM -0700, Liu Bo wrote:
> > > > That's EIO. Sometimes the EIO is big enough we have to abort, but
> > > > really the abort is just adding bonus.
> > >
> > > I think we misuse the EIO where we should really return EFSCORRUPTED
> > > that's an alias for EUCLEAN, looking at xfs or ext4. EIO should be
> > > really a message that the hardware is bad.
> >
> > I love this idea, but one quick question, when returning EUCLEAN, what
> > message do users get?
> >
> > "#define EUCLEAN 117 /* Structure needs cleaning */"
>
> strerror(EUCLEAN) -> "Structure needs cleaning"
Hmm, if I was the user, I'm not sure how to deal with "Structure needs cleaning", so still need to take a glance at dmesg log.
Thanks,
-liubo
next prev parent reply other threads:[~2016-09-20 18:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 16:27 [PATCH] Btrfs: kill BUG_ON in do_relocation Liu Bo
2016-09-14 17:13 ` Josef Bacik
2016-09-14 17:29 ` Chris Mason
2016-09-14 17:31 ` Josef Bacik
2016-09-14 18:19 ` Liu Bo
2016-09-15 19:01 ` Liu Bo
2016-09-15 18:58 ` Chris Mason
2016-09-19 18:01 ` David Sterba
2016-09-19 23:11 ` Liu Bo
2016-09-20 8:03 ` David Sterba
2016-09-20 17:59 ` Liu Bo [this message]
2016-09-21 8:14 ` David Sterba
2016-09-14 18:16 ` Liu Bo
2016-09-23 21:05 ` [PATCH v2] " Liu Bo
2016-10-11 14:25 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920175959.GB3319@localhost.localdomain \
--to=bo.li.liu@oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).