From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:39568 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932413AbcI3Jx0 (ORCPT ); Fri, 30 Sep 2016 05:53:26 -0400 Date: Fri, 30 Sep 2016 11:53:24 +0200 From: David Sterba To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org, Mark Fasheh Subject: Re: [PATCH] btrfs-progs: qgroup: Fix regression leads to corrupted qgroup status Message-ID: <20160930095324.GH5531@suse.cz> Reply-To: dsterba@suse.cz References: <20160907025419.23284-1-quwenruo@cn.fujitsu.com> <20160929171859.GE5531@twin.jikos.cz> <98881736-4b95-bae3-2f9d-93a2a1b615fd@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <98881736-4b95-bae3-2f9d-93a2a1b615fd@cn.fujitsu.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Fri, Sep 30, 2016 at 08:44:58AM +0800, Qu Wenruo wrote: > > > At 09/30/2016 01:19 AM, David Sterba wrote: > > On Wed, Sep 07, 2016 at 10:54:19AM +0800, Qu Wenruo wrote: > >> Commit 93dabf211d74daf6e3de642bdd887a90a00f7b49 > >> Author: Mark Fasheh > >> Date: Fri Jun 17 13:37:48 2016 -0700 > >> > >> btrfs-progs: check: verify qgroups above level 0 > >> > >> This commit introduced a new regression which corrupts > >> read_qgroup_status, since it iterate leaf with manually specified slot, > >> not correct path->slot[0]. > >> > >> This leads to wrong slot[0] and read_qgroup_status() will read out wrong > >> flags, leading to regression. > >> > >> Fix read_qgroup_status() by using eb and slot instread of wrong path > >> strucutre. > >> > >> Reported-by: Tsutomu Itoh > >> Cc: Mark Fasheh > >> Signed-off-by: Qu Wenruo > > > > I'm adding this patch to devel. Do you have a test for the regression please? > > > > > Xfstests btrfs/114 can produce it. Good. > If you mean to add btrfs-progs test case, then I can try to create a > minimal image to reproduce it. Yes please.