Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Roman Mamedov <rm@romanrm.net>
To: Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: Unable to open ctree
Date: Mon, 3 Oct 2016 01:22:25 +0500	[thread overview]
Message-ID: <20161003012225.089c4d38@natsu> (raw)
In-Reply-To: <CAJCQCtTr3tG_8YSB_8gfBkpy558HKC+cz394B0wH2Je3v9kZmQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

On Sun, 2 Oct 2016 13:29:56 -0600
Chris Murphy <lists@colorremedies.com> wrote:

> Well short of a bug, the problem aren't the checksums. The problem is
> the metadata is wrong, so if you recalculate checksums you're likely
> end up with an even more corrupted file system because it'll start out
> trusting bad metadata.

It appears that metadata got created with profile "single", because the device
is SSD. If this was DUP metadata, this entire problem wouldn't happen.
It is a terrible idea to downgrade metadata to single on detecting SSDs at
mkfs. The original rationale was that "SSDs will deduplicate it anyways", but
there are many ways things can corrupt way before reaching the SSD (from the
point of view of which it will look like the computer sent two different
metadata blocks, if one got corrupted in flight), and secondly, the ability of
SSDs to perfectly deduplicate small 4K sized pieces of data at hundreds of
megabytes in read/write speeds is VASTLY overestimated here.


-- 
With respect,
Roman

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2016-10-02 20:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-02 18:17 Unable to open ctree Leonidas Spyropoulos
2016-10-02 19:29 ` Chris Murphy
2016-10-02 20:12   ` Leonidas Spyropoulos
2016-10-02 20:22   ` Roman Mamedov [this message]
2016-10-02 20:27     ` Chris Murphy
2016-10-02 22:05       ` Leonidas Spyropoulos
2016-10-02 20:46     ` Leonidas Spyropoulos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161003012225.089c4d38@natsu \
    --to=rm@romanrm.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox