linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 0/4] Btrfs-convert: Add support to copy common inode flags
Date: Fri, 14 Oct 2016 16:57:39 +0200	[thread overview]
Message-ID: <20161014145739.GA11398@suse.cz> (raw)
In-Reply-To: <41c42235-ef89-1f5c-28cc-bf3275045737@cn.fujitsu.com>

On Fri, Oct 14, 2016 at 08:50:31AM +0800, Qu Wenruo wrote:
> > I can pull the branches from you, either to devel or integration. Please
> > base them on the last release point (ie. master) if there are no other
> > dependencies. Otherwise, I'll publish a branch that contains the desired
> > patches and will promise not to change it with rebases.
> 
> Sorry I'm not very familiar with when to send a pull request and when to 
> send normal patches, and to which branch it should be rebased to.

It's no required, just would make a few things easier. The pull is
additional to mailinglist patches, so send patches as usual.  If you put
the patches to a branch that I can pull, I'll do that eventually. This
happens if the patches are in a state that I don't need to touch them at
all or do just minor modifications.

>  From my understanding, for large patchset pull request is preferred(and 
> patchse should still be sent out for review) and for small changes, 
> normal mail should be good enough.

Basically yes. Single patches or very short series do not need to go
through git (just mails).

> And normally I rebase all my branches/patches to your devel branch.
> Or should I rebase them to the master branch?

As the devel branch could be rebased, it's not suitable as a starting
point. Even if you rebase it, I might not be able to pull it if
something changes in the meantime. As I don't process progs patches
every day, this is likely to happen.

If you don't want to do the git way now, no big deal. It's a long term
goal, but this requires to do the things right, so both parties,
develoeprs and maintainers, know what to expect and get it. I'll also
write that to wiki for future reference.

      reply	other threads:[~2016-10-14 14:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-11  2:44 [PATCH v2 0/4] Btrfs-convert: Add support to copy common inode flags Qu Wenruo
2016-10-11  2:44 ` [PATCH v2 1/4] btrfs-progs: Copy btrfs inode flags from kernel header Qu Wenruo
2016-10-11  2:44 ` [PATCH v2 2/4] btrfs-progs: Make btrfs-debug-tree print all readable strings for inode flags Qu Wenruo
2016-10-11  2:44 ` [PATCH v2 3/4] btrfs-progs: convert: Convert ext inode flags to btrfs " Qu Wenruo
2016-10-11  2:44 ` [PATCH v2 4/4] btrfs-progs: convert-test: Add test case for common " Qu Wenruo
     [not found] ` <20161013141558.GW11398@twin.jikos.cz>
2016-10-14  0:50   ` [PATCH v2 0/4] Btrfs-convert: Add support to copy " Qu Wenruo
2016-10-14 14:57     ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161014145739.GA11398@suse.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).