From: Roman Mamedov <rm@romanrm.net>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: Divya Indi <divya.indi@oracle.com>, <linux-btrfs@vger.kernel.org>,
<ashish.samant@oracle.com>, <bo.li.liu@oracle.com>
Subject: Re: [PATCH 2/3] btrfs-progs: Add a command to show bg info
Date: Tue, 18 Oct 2016 10:24:24 +0500 [thread overview]
Message-ID: <20161018102424.59fb14e4@natsu> (raw)
In-Reply-To: <d9e5bee8-d865-840d-11e4-74f98c34282e@cn.fujitsu.com>
On Tue, 18 Oct 2016 09:39:32 +0800
Qu Wenruo <quwenruo@cn.fujitsu.com> wrote:
> > static const char * const cmd_inspect_inode_resolve_usage[] = {
> > "btrfs inspect-internal inode-resolve [-v] <inode> <path>",
> > "Get file system paths for the given inode",
> > @@ -702,6 +814,8 @@ const struct cmd_group inspect_cmd_group = {
> > 0 },
> > { "min-dev-size", cmd_inspect_min_dev_size,
> > cmd_inspect_min_dev_size_usage, NULL, 0 },
> > + { "bg_analysis", cmd_inspect_bg_analysis,
> > + cmd_inspect_bg_analysis_usage, NULL, 0 },
>
> Just naming preference, IMHO show-block-groups or dump-block-groups
> seems better for me.
And in any case please don't mix separation by "-" and "_" in the same command
string. In btrfs tool the convention is to separate words in subcommand names
using "-".
--
With respect,
Roman
next prev parent reply other threads:[~2016-10-18 5:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 0:35 btrfs-progs: Add 2 new subcommands to inspect-internal Divya Indi
2016-10-18 0:35 ` [PATCH 1/3] btrfs-progs: Generic functions to retrieve chunks and their bg info Divya Indi
2016-10-18 0:35 ` [PATCH 2/3] btrfs-progs: Add a command to show " Divya Indi
2016-10-18 0:35 ` [PATCH 3/3] btrfs-progs: Add command to check if balance op is req Divya Indi
2016-10-18 1:42 ` Qu Wenruo
2016-10-19 17:08 ` Divya Indi
2016-10-28 15:20 ` David Sterba
2016-10-28 16:29 ` Graham Cobb
2016-10-31 16:33 ` David Sterba
2016-11-02 0:39 ` divya.indi
2016-10-30 14:10 ` Qu Wenruo
2016-10-18 1:39 ` [PATCH 2/3] btrfs-progs: Add a command to show bg info Qu Wenruo
2016-10-18 5:24 ` Roman Mamedov [this message]
2016-10-19 17:33 ` Divya Indi
2016-10-28 16:00 ` David Sterba
2016-11-02 0:40 ` divya.indi
2016-10-18 1:34 ` [PATCH 1/3] btrfs-progs: Generic functions to retrieve chunks and their " Qu Wenruo
2016-10-28 15:44 ` David Sterba
2016-11-02 0:39 ` divya.indi
2017-06-07 17:03 ` Goffredo Baroncelli
2017-06-09 21:57 ` divya.indi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018102424.59fb14e4@natsu \
--to=rm@romanrm.net \
--cc=ashish.samant@oracle.com \
--cc=bo.li.liu@oracle.com \
--cc=divya.indi@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).