From: "Domagoj Tršan" <domagoj.trsan@gmail.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org, clm@fb.com,
jbacik@fb.com, dsterba@suse.com
Subject: Re: [PATCH] btrfs: change btrfs_csum_final result param type to u8
Date: Fri, 21 Oct 2016 12:51:17 +0100 [thread overview]
Message-ID: <20161021115117.cuh6x7o3s3ow6pte@nemesis> (raw)
In-Reply-To: <20161012144319.GQ11398@twin.jikos.cz>
On 2016-10-12 16:43 +0200, David Sterba wrote:
> On Mon, Sep 19, 2016 at 07:22:28PM +0200, David Sterba wrote:
> > On Sun, Sep 18, 2016 at 12:10:34AM +0100, Domagoj Tršan wrote:
> > > csum member of struct btrfs_super_block has array type of u8. It makes sense
> > > that function btrfs_csum_final should be also declared to accept u8 *. I
> > > changed the declaration of method void btrfs_csum_final(u32 crc, char *result);
> > > to void btrfs_csum_final(u32 crc, u8 *result);
> >
> > You should put a similar text to the patch itself, it's not necessary to
> > send the cover letter for single patches. Otherwise the change is ok.
>
> Please update the patch according to the above and resend.
Hi David,
apologies for the delay. I sent the new version patch.
Cheers!
--
(\/)(;,,;)(\/)
prev parent reply other threads:[~2016-10-21 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 23:10 [PATCH] btrfs: change btrfs_csum_final result param type to u8 Domagoj Tršan
2016-09-17 23:10 ` Domagoj Tršan
2016-09-19 17:22 ` David Sterba
2016-10-12 14:43 ` David Sterba
2016-10-21 11:51 ` Domagoj Tršan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021115117.cuh6x7o3s3ow6pte@nemesis \
--to=domagoj.trsan@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).