From: Tejun Heo <htejun@fb.com>
To: Josef Bacik <jbacik@fb.com>
Cc: <linux-btrfs@vger.kernel.org>, <kernel-team@fb.com>,
<david@fromorbit.com>, <jack@suse.cz>,
<linux-fsdevel@vger.kernel.org>, <viro@zeniv.linux.org.uk>,
<hch@infradead.org>, <jweiner@fb.com>
Subject: Re: [PATCH 1/5] remove mapping from balance_dirty_pages*()
Date: Tue, 25 Oct 2016 14:47:52 -0400 [thread overview]
Message-ID: <20161025184751.GA13857@htj.duckdns.org> (raw)
In-Reply-To: <1477420904-1399-2-git-send-email-jbacik@fb.com>
On Tue, Oct 25, 2016 at 02:41:40PM -0400, Josef Bacik wrote:
> The only reason we pass in the mapping is to get the inode in order to see if
> writeback cgroups is enabled, and even then it only checks the bdi and a super
> block flag. balance_dirty_pages() doesn't even use the mapping. Since
> balance_dirty_pages*() works on a bdi level, just pass in the bdi and super
> block directly so we can avoid using mapping. This will allow us to still use
> balance_dirty_pages for dirty metadata pages that are not backed by an
> address_mapping.
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2016-10-25 18:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 18:41 [PATCH 0/5][RESEND] Support for metadata specific accounting Josef Bacik
2016-10-25 18:41 ` [PATCH 1/5] remove mapping from balance_dirty_pages*() Josef Bacik
2016-10-25 18:47 ` Tejun Heo [this message]
2016-10-25 18:41 ` [PATCH 2/5] writeback: convert WB_WRITTEN/WB_DIRITED counters to bytes Josef Bacik
2016-10-25 19:03 ` Tejun Heo
2016-10-25 19:09 ` Josef Bacik
2016-10-30 15:13 ` Jan Kara
2016-10-25 18:41 ` [PATCH 3/5] writeback: add counters for metadata usage Josef Bacik
2016-10-25 19:50 ` Tejun Heo
2016-10-26 15:20 ` Josef Bacik
2016-10-26 15:49 ` Tejun Heo
2016-10-30 15:36 ` Jan Kara
2016-10-25 18:41 ` [PATCH 4/5] writeback: introduce super_operations->write_metadata Josef Bacik
2016-10-25 20:00 ` Tejun Heo
2016-10-25 18:41 ` [PATCH 5/5] fs: don't set *REFERENCED unless we are on the lru list Josef Bacik
2016-10-25 22:01 ` Dave Chinner
2016-10-25 23:36 ` Dave Chinner
2016-10-26 20:03 ` Josef Bacik
2016-10-26 22:20 ` Dave Chinner
2016-10-26 15:11 ` Josef Bacik
2016-10-27 0:30 ` Dave Chinner
2016-10-27 13:13 ` Josef Bacik
2016-10-28 3:48 ` Dave Chinner
2016-10-25 22:44 ` Omar Sandoval
2016-10-26 4:17 ` [PATCH 5/5] " Andreas Dilger
2016-10-26 5:24 ` Omar Sandoval
-- strict thread matches above, loose matches on Subject: below --
2016-10-24 20:43 [PATCH 0/5] Support for metadata specific accounting Josef Bacik
2016-10-24 20:43 ` [PATCH 1/5] remove mapping from balance_dirty_pages*() Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025184751.GA13857@htj.duckdns.org \
--to=htejun@fb.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=jweiner@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).