From: Tobias Klauser <tklauser@distanz.ch>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: clm@fb.com, jbacik@fb.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] btrfs: Remove some dead code
Date: Thu, 3 Nov 2016 13:43:50 +0100 [thread overview]
Message-ID: <20161103124349.GA819@distanz.ch> (raw)
In-Reply-To: <20161101102606.27006-1-christophe.jaillet@wanadoo.fr>
On 2016-11-01 at 11:26:06 +0100, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> 'btrfs_iget()' can not return an error pointer, so this test can be
> removed.
This descrption does not match what the patch actually does. Shouldn't
it say "...can not return NULL, so this test can be removed."?
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> fs/btrfs/free-space-cache.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
> index e4b48f377d3a..afd8b0c10acd 100644
> --- a/fs/btrfs/free-space-cache.c
> +++ b/fs/btrfs/free-space-cache.c
> @@ -75,8 +75,6 @@ static struct inode *__lookup_free_space_inode(struct btrfs_root *root,
> btrfs_release_path(path);
>
> inode = btrfs_iget(root->fs_info->sb, &location, root, NULL);
> - if (!inode)
> - return ERR_PTR(-ENOENT);
> if (IS_ERR(inode))
> return inode;
> if (is_bad_inode(inode)) {
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-11-03 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 10:26 [PATCH] btrfs: Remove some dead code Christophe JAILLET
2016-11-02 14:30 ` David Sterba
2016-11-03 12:43 ` Tobias Klauser [this message]
2016-11-03 18:24 ` Christophe JAILLET
-- strict thread matches above, loose matches on Subject: below --
2017-04-11 8:57 [PATCH] Btrfs: remove " Dan Carpenter
2017-04-12 13:36 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103124349.GA819@distanz.ch \
--to=tklauser@distanz.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).