From: David Sterba <dsterba@suse.cz>
To: ethanwu <ethanwu@synology.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs-progs: check: Handle drop_progress correctly for deleted subvolume
Date: Tue, 15 Nov 2016 17:00:37 +0100 [thread overview]
Message-ID: <20161115160037.GR12522@twin.jikos.cz> (raw)
In-Reply-To: <1476356989-23131-1-git-send-email-ethanwu@synology.com>
Hi,
On Thu, Oct 13, 2016 at 07:09:47PM +0800, ethanwu wrote:
> The patchsets fixes 2 problems in checking deleted subvolume.
>
> First, there are cases missing in checking drop_key, this add up the missing cases,
> so the skipping flow could work correctly.
>
> Second, the drop key is only applied to subvolume tree. This should be applied to the
> corresponding relocation tree of the deleted subvolume as well.
the changelogs are very good, unfortunatelly I'm not very familiar with
the parts so I'd need a review from somebody else, otherwise the patches
will be on a slow merge path. Would be good if you could provide crafted
images where the bug exhibits. Thanks.
prev parent reply other threads:[~2016-11-15 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 11:09 [PATCH 0/2] btrfs-progs: check: Handle drop_progress correctly for deleted subvolume ethanwu
2016-10-13 11:09 ` [PATCH 1/2] btrfs-progs: check: skip keys prior to drop key in deleted subvolume correctly ethanwu
2016-10-13 11:09 ` [PATCH 2/2] btrfs-progs: check: add drop key to relocation tree ethanwu
2016-11-15 16:00 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115160037.GR12522@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=ethanwu@synology.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).