From: Christoph Hellwig <hch@lst.de>
To: Omar Sandoval <osandov@osandov.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 6/9] btrfs: calculate end of bio offset properly
Date: Tue, 22 Nov 2016 10:42:40 +0100 [thread overview]
Message-ID: <20161122094240.GA15407@lst.de> (raw)
In-Reply-To: <20161118200438.GF19038@vader.DHCP.thefacebook.com>
On Fri, Nov 18, 2016 at 12:04:38PM -0800, Omar Sandoval wrote:
> > +static u64 bio_end_offset(struct bio *bio)
> > +{
> > + struct bio_vec *last = &bio->bi_io_vec[bio->bi_vcnt - 1];
> > +
> > + return page_offset(last->bv_page) + last->bv_len - last->bv_offset;
>
> Why is this minus bv_offset and not plus? Am I misunderstanding
> bv_offset?
This should be a plus, thanks.
Can anyone help me on how to get test coverage for the compression
code?
next prev parent reply other threads:[~2016-11-22 9:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 12:52 don't poke into bio internals Christoph Hellwig
2016-11-16 12:52 ` [PATCH 1/9] btrfs: use bio iterators for the decompression handlers Christoph Hellwig
2016-11-19 1:29 ` Liu Bo
2016-11-22 9:38 ` Christoph Hellwig
2016-11-22 20:32 ` Liu Bo
2016-11-16 12:52 ` [PATCH 2/9] btrfs: don't access the bio directly in the raid5/6 code Christoph Hellwig
2016-11-18 19:05 ` Omar Sandoval
2016-11-16 12:52 ` [PATCH 3/9] " Christoph Hellwig
2016-11-18 19:34 ` Omar Sandoval
2016-11-16 12:52 ` [PATCH 4/9] btrfs: don't access the bio directly in btrfs_csum_one_bio Christoph Hellwig
2016-11-18 19:39 ` Omar Sandoval
2016-11-16 12:52 ` [PATCH 5/9] btrfs: use bi_size Christoph Hellwig
2016-11-18 19:48 ` Omar Sandoval
2016-11-16 12:52 ` [PATCH 6/9] btrfs: calculate end of bio offset properly Christoph Hellwig
2016-11-18 20:04 ` Omar Sandoval
2016-11-22 9:42 ` Christoph Hellwig [this message]
2016-11-22 18:58 ` Omar Sandoval
2016-11-23 4:21 ` Anand Jain
2016-11-23 4:21 ` Omar Sandoval
2016-11-23 4:32 ` Anand Jain
2016-11-23 4:47 ` Omar Sandoval
2016-11-16 12:52 ` [PATCH 7/9] btrfs: refactor __btrfs_lookup_bio_sums to use bio_for_each_segment_all Christoph Hellwig
2016-11-18 20:31 ` Omar Sandoval
2016-11-16 12:52 ` [PATCH 8/9] btrfs: use bio_for_each_segment_all in __btrfsic_submit_bio Christoph Hellwig
2016-11-18 20:36 ` Omar Sandoval
2016-11-16 12:52 ` [PATCH 9/9] btrfs: only check bio size to see if a repair bio should have the failfast flag Christoph Hellwig
2016-11-16 16:19 ` don't poke into bio internals David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122094240.GA15407@lst.de \
--to=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).