From: Liu Bo <bo.li.liu@oracle.com>
To: Chris Mason <clm@fb.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.cz>,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH] Btrfs: fix truncate down when no_holes feature is enabled
Date: Tue, 22 Nov 2016 12:08:47 -0800 [thread overview]
Message-ID: <20161122200847.GA23828@localhost.localdomain> (raw)
In-Reply-To: <e740caa9-33a8-7aa0-b4a4-c6fc22be4d3e@fb.com>
On Tue, Nov 22, 2016 at 02:13:21PM -0500, Chris Mason wrote:
> On 11/11/2016 05:27 PM, Liu Bo wrote:
> > For such a file mapping,
> >
> > [0-4k][hole][8k-12k]
> >
> > In NO_HOLES mode, we don't have the [hole] extent any more.
> > Commit c1aa45759e90 ("Btrfs: fix shrinking truncate when the no_holes feature is enabled")
> > fixed disk isize not being updated in NO_HOLES mode when data is not flushed.
> >
> > However, even if data has been flushed, we can still have trouble
> > in updating disk isize since we updated disk isize to 'start' of
> > the last evicted extent.
> >
> > Also add a ASSERT for better catching (for developers only).
> >
> > Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
>
> Thanks Liu!
>
> Reviewed-by: Chris Mason <clm@fb.com>
The added ASSERT() can cause generic/068 to crash because I didn't
filter out the 'log tree' case, I'm testing a V2 patch.
Thanks,
-liubo
next prev parent reply other threads:[~2016-11-22 20:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 22:27 [PATCH] Btrfs: fix truncate down when no_holes feature is enabled Liu Bo
2016-11-22 19:13 ` Chris Mason
2016-11-22 20:08 ` Liu Bo [this message]
2016-11-23 16:55 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122200847.GA23828@localhost.localdomain \
--to=bo.li.liu@oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=fdmanana@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).