From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Omar Sandoval <osandov@osandov.com>,
linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org,
Qu Wenruo <quwenruo@cn.fujitsu.com>,
kernel-team@fb.com
Subject: Re: [RFC PATCH 0/2] Btrfs: make a source length of 0 imply EOF for dedupe
Date: Tue, 22 Nov 2016 13:17:19 -0800 [thread overview]
Message-ID: <20161122211719.GD16801@birch.djwong.org> (raw)
In-Reply-To: <20161118053853.GC31780@infradead.org>
On Thu, Nov 17, 2016 at 09:38:53PM -0800, Christoph Hellwig wrote:
> On Thu, Nov 17, 2016 at 04:07:48PM -0800, Omar Sandoval wrote:
> > So now we have 3 options:
> >
> > a) Apply these patches as-is.
> > b) Fix XFS to both return the actual bytes_deduped and cap the length
> > for the EOF case. Do the same for Btrfs.
> > c) Make XFS consistent with the existing Btrfs behavior.
> >
> > I'm starting to lean towards option c after writing this cover letter,
> > but I might as well send these out and get a second opinion.
>
> I agree - btrfs was there first, and there is no fatal flaw in the ABI,
> so let's adjust XFS to it.
Ok. I'll send in a fix for generic/182, a patch to fix XFS, and I'll
roll the same fix into the ocfs2 patches before the next submission.
--D
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-11-22 21:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 0:07 [RFC PATCH 0/2] Btrfs: make a source length of 0 imply EOF for dedupe Omar Sandoval
2016-11-18 0:07 ` [RFC PATCH 1/2] Btrfs: refactor btrfs_extent_same() slightly Omar Sandoval
2016-11-18 3:22 ` Qu Wenruo
2016-11-18 0:07 ` [RFC PATCH 2/2] Btrfs: make a source length of 0 imply EOF for dedupe Omar Sandoval
2016-11-18 5:38 ` [RFC PATCH 0/2] " Christoph Hellwig
2016-11-22 21:17 ` Darrick J. Wong [this message]
2016-11-23 2:02 ` Zygo Blaxell
2016-11-23 2:44 ` Darrick J. Wong
2016-11-24 5:16 ` Zygo Blaxell
2016-11-23 4:26 ` Dave Chinner
2016-11-23 13:55 ` Zygo Blaxell
2016-11-23 22:13 ` Dave Chinner
2016-11-23 23:14 ` Zygo Blaxell
2016-11-23 23:53 ` Dave Chinner
2016-11-24 1:26 ` Darrick J. Wong
2016-11-25 4:20 ` Zygo Blaxell
2016-11-28 17:58 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122211719.GD16801@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).