From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
linux-btrfs@vger.kernel.org, dsterba@suse.com
Subject: Re: [PATCH 1/2] btrfs-progs: btrfs-convert: Prevent accounting blocks beyond end of device
Date: Wed, 14 Dec 2016 13:38:13 +0100 [thread overview]
Message-ID: <20161214123813.GC3620@twin.jikos.cz> (raw)
In-Reply-To: <799009dd-e227-4c84-ab6a-08883e6a32c7@cn.fujitsu.com>
On Fri, Dec 09, 2016 at 09:03:57AM +0800, Qu Wenruo wrote:
> Hi Chandan,
>
> Thanks for the patch.
>
> At 12/08/2016 09:56 PM, Chandan Rajendra wrote:
> > When looping across data block bitmap, __ext2_add_one_block() may add
> > blocks which do not exist on the underlying disk. This commit prevents
> > this from happening by checking the block index against the maximum
> > block count that was present in the ext4 filesystem instance that is
> > being converted.
>
> The patch looks good to me.
>
> Reviewed-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Applied, thanks.
next prev parent reply other threads:[~2016-12-14 12:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 13:56 [PATCH 1/2] btrfs-progs: btrfs-convert: Prevent accounting blocks beyond end of device Chandan Rajendra
2016-12-08 13:56 ` [PATCH 2/2] btrfs-convert: Fix migrate_super_block() to work with 64k sectorsize Chandan Rajendra
2016-12-09 1:09 ` Qu Wenruo
2016-12-09 5:15 ` Chandan Rajendra
2016-12-14 12:38 ` David Sterba
2016-12-09 1:03 ` [PATCH 1/2] btrfs-progs: btrfs-convert: Prevent accounting blocks beyond end of device Qu Wenruo
2016-12-09 4:36 ` Chandan Rajendra
2016-12-14 12:38 ` David Sterba [this message]
2016-12-09 1:04 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214123813.GC3620@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=chandan@linux.vnet.ibm.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).