linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] btrfs: uuid-tree: btrfs_uuid_tree_iterate: fix improper return value
@ 2017-01-12 14:55 Milan Stephan
  2017-01-12 15:03 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Milan Stephan @ 2017-01-12 14:55 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-kernel, Chris Mason, Josef Bacik, David Sterba, linux-btrfs,
	Pan Bian, Milan Stephan, Thomas Preisner

From: Milan Stephan <milan.stephan+linux@fau.de>

Fixes return value of btrfs_uuid_tree_iterate to catch and return errors
when calling btrfs_alloc_path.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731

Reported-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Milan Stephan <milan.stephan+linux@fau.de>
Signed-off-by: Thomas Preisner <thomas.preisner+linux@fau.de>
---
 fs/btrfs/uuid-tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/uuid-tree.c b/fs/btrfs/uuid-tree.c
index 161342b..12f873d 100644
--- a/fs/btrfs/uuid-tree.c
+++ b/fs/btrfs/uuid-tree.c
@@ -354,5 +354,5 @@ int btrfs_uuid_tree_iterate(struct btrfs_fs_info *fs_info,
 	btrfs_free_path(path);
 	if (ret)
 		btrfs_warn(fs_info, "btrfs_uuid_tree_iterate failed %d", ret);
-	return 0;
+	return ret;
 }
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] btrfs: uuid-tree: btrfs_uuid_tree_iterate: fix improper return value
  2017-01-12 14:55 [PATCH] btrfs: uuid-tree: btrfs_uuid_tree_iterate: fix improper return value Milan Stephan
@ 2017-01-12 15:03 ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2017-01-12 15:03 UTC (permalink / raw)
  To: Milan Stephan
  Cc: linux-kernel, Pan Bian, Milan Stephan, Thomas Preisner,
	Chris Mason, Josef Bacik, linux-kernel, linux-btrfs

On Thu, Jan 12, 2017 at 03:55:45PM +0100, Milan Stephan wrote:
> From: Milan Stephan <milan.stephan+linux@fau.de>
> 
> Fixes return value of btrfs_uuid_tree_iterate to catch and return errors
> when calling btrfs_alloc_path.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731

The patch for that has been already sent and merged to for-next,
https://git.kernel.org/cgit/linux/kernel/git/kdave/linux.git/commit/?h=for-next&id=73ba39ab9307340dc98ec3622891314bbc09cc2e

but thanks anyway.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-12 15:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-12 14:55 [PATCH] btrfs: uuid-tree: btrfs_uuid_tree_iterate: fix improper return value Milan Stephan
2017-01-12 15:03 ` David Sterba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).