From: David Sterba <dsterba@suse.cz>
To: Omar Sandoval <osandov@osandov.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.com>,
Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
kernel-team@fb.com
Subject: Re: [PATCH] Btrfs: constify struct btrfs_{,disk_}key wherever possible
Date: Fri, 20 Jan 2017 19:11:47 +0100 [thread overview]
Message-ID: <20170120181146.GD11951@twin.jikos.cz> (raw)
In-Reply-To: <28e17c356a456cd03635e6c6f2c7a46c82de45ac.1484724045.git.osandov@fb.com>
On Tue, Jan 17, 2017 at 11:24:37PM -0800, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> In a lot of places, it's unclear when it's safe to reuse a struct
> btrfs_key after it has been passed to a helper function. Constify these
> arguments wherever possible to make it obvious.
>
> Signed-off-by: Omar Sandoval <osandov@fb.com>
> ---
> This applies to Dave's for-next branch. If it's too intrusive of a
> change, it can wait, but I think it's a nice cleanup.
Applies cleanly on the for 4.11 branch (that now has most of for-next),
thanks.
prev parent reply other threads:[~2017-01-20 18:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 7:24 [PATCH] Btrfs: constify struct btrfs_{,disk_}key wherever possible Omar Sandoval
2017-01-20 18:11 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120181146.GD11951@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).