From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: lowmem-check: Fix false alert on dropped leaf
Date: Fri, 20 Jan 2017 19:21:37 +0100 [thread overview]
Message-ID: <20170120182137.GF11951@twin.jikos.cz> (raw)
In-Reply-To: <20170118052107.7394-1-quwenruo@cn.fujitsu.com>
On Wed, Jan 18, 2017 at 01:21:07PM +0800, Qu Wenruo wrote:
> For btrfs-progs test case 021-partially-dropped-snapshot-case, if the
> first leaf is already dropped, btrfs check low-memory mode will report
> false alert:
>
> checking fs roots
> checksum verify failed on 29917184 found E4E3BDB6 wanted 00000000
> checksum verify failed on 29917184 found E4E3BDB6 wanted 00000000
> checksum verify failed on 29917184 found E4E3BDB6 wanted 00000000
> checksum verify failed on 29917184 found E4E3BDB6 wanted 00000000
>
> This is caused by we are calling check_fs_first_inode() function,
> unlike the rest part of check_fs_root_v2(), it doesn't have enough check
> on dropping progress, and caused the false alert.
>
> Fix it by checking dropping progress before searching slot.
>
> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Applied, thanks.
prev parent reply other threads:[~2017-01-20 18:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 5:21 [PATCH] btrfs-progs: lowmem-check: Fix false alert on dropped leaf Qu Wenruo
2017-01-20 18:21 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120182137.GF11951@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).