From: "Lakshmipathi.G" <lakshmipathi.g@giis.co.in>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: fsck-tests: missing csum test script
Date: Thu, 26 Jan 2017 01:22:04 +0530 [thread overview]
Message-ID: <20170125195204.GB10888@giis.co.in> (raw)
In-Reply-To: <20170117150627.GR12081@twin.jikos.cz>
On Tue, Jan 17, 2017 at 04:06:27PM +0100, David Sterba wrote:
> It's not clear from the test what's the purpose. There's one corrupted
> csum but the whole csum tree rebuild option is used. This is a pretty
> basic check that the --init-csum-tree works, so it should be mentioned
> somewhere in the test script.
I'll rename directory to 027-verify-init-csum-tree instead of current one.
Is it possible, to fix only the corrupted csum instead of re-building the
csum-tree?
>
> Please don't use btrfs-debug-tree, it's been obsoleted by the dump-tree
> subcommand. And you can use the '-t csum' option to dump just the csum
> tree.
>
> This can be simplified to one sed command.
>
>
> Here we want to capture the output from 'check' for analysis in case of
> problems.
>
Will fix above three issues with next patch.
prev parent reply other threads:[~2017-01-25 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 19:26 [PATCH] btrfs-progs: fsck-tests: missing csum test script Lakshmipathi.G
2017-01-17 15:06 ` David Sterba
2017-01-25 19:52 ` Lakshmipathi.G [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125195204.GB10888@giis.co.in \
--to=lakshmipathi.g@giis.co.in \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).