linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Chris Murphy <lists@colorremedies.com>
Cc: Btrfs BTRFS <linux-btrfs@vger.kernel.org>, agruenba@redhat.com
Subject: Re: read-only fs, kernel 4.9.0, fs/btrfs/delayed-inode.c:1170 __btrfs_run_delayed_items,
Date: Wed, 25 Jan 2017 14:58:14 -0800	[thread overview]
Message-ID: <20170125225814.GA15621@vader> (raw)
In-Reply-To: <CAJCQCtQiVAYDZM9WeucFgJANbQhb_G5fTE-2Jpo3fc3Ch_RPhQ@mail.gmail.com>

On Wed, Jan 25, 2017 at 03:55:33PM -0700, Chris Murphy wrote:
> On Tue, Jan 24, 2017 at 9:42 PM, Omar Sandoval <osandov@osandov.com> wrote:
> > On Tue, Jan 24, 2017 at 07:53:06PM -0700, Chris Murphy wrote:
> >> On Tue, Jan 24, 2017 at 3:50 PM, Omar Sandoval <osandov@osandov.com> wrote:
> >>
> >> > Got this to repro after installing systemd-container. It's happening on
> >> > lsetxattr() to set the SELinux context on /var/lib/machines, which is a
> >> > subvolume. Looking into it now. Thanks for all of the help, Chris.
> >>
> >> Aha! So the snapshot part was a goose chase, it has nothing to do with
> >> that, really. Because I'm taking a snapshot of root, the nested
> >> /var/lib/machines subvolume is not in that snapshot, so now it has to
> >> be created by systemd at next boot and the proper selinux label set on
> >> it.
> >>
> >> It means there's something different about subvolumes and directories
> >> when it comes to xattrs, and the xattr patch I found in bisect is
> >> exposing the difference, hence things getting tripped up.
> >
> > The snapshots were actually the key -- the error was because setxattr()
> > was being allowed on the read-only directory created in the place of the
> > /var/lib/machines subvolume. Not sure if you saw the patch I sent up,
> > but this should fix it: https://patchwork.kernel.org/patch/9536307/
> 
> Got it.
> 
> I couldn't get it to apply to 4.9, but it goes on 4.10-rc5 and the
> problem is fixed.

Sweet, can I add your tested-by?

  reply	other threads:[~2017-01-25 22:58 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 18:50 read-only fs, kernel 4.9.0, fs/btrfs/delayed-inode.c:1170 __btrfs_run_delayed_items, Chris Murphy
2017-01-11  1:07 ` Chris Murphy
2017-01-11 23:13   ` Chris Murphy
2017-01-18 21:27     ` Chris Murphy
2017-01-19 18:05       ` Imran Geriskovan
2017-01-23 21:31       ` Omar Sandoval
2017-01-23 21:50         ` Chris Murphy
2017-01-23 21:55           ` Chris Murphy
2017-01-23 22:04             ` Omar Sandoval
2017-01-23 23:48               ` Chris Murphy
2017-01-24  0:05                 ` Omar Sandoval
2017-01-24  3:51                   ` Chris Murphy
2017-01-24 17:49                     ` Omar Sandoval
2017-01-24 18:37                       ` Chris Murphy
2017-01-24 18:56                         ` Omar Sandoval
2017-01-24 19:06                           ` Chris Murphy
2017-01-24 19:19                             ` Chris Murphy
2017-01-24 20:10                               ` Omar Sandoval
2017-01-24 20:24                                 ` Chris Murphy
2017-01-24 20:27                                   ` Omar Sandoval
2017-01-24 20:33                                     ` Chris Murphy
2017-01-24 20:48                                       ` Chris Murphy
2017-01-24 22:50                                         ` Omar Sandoval
2017-01-25  2:53                                           ` Chris Murphy
2017-01-25  4:42                                             ` Omar Sandoval
2017-01-25 22:55                                               ` Chris Murphy
2017-01-25 22:58                                                 ` Omar Sandoval [this message]
2017-01-25 23:07                                                   ` Chris Murphy
2017-01-24 20:13                               ` Chris Murphy
2017-01-24 20:17                                 ` Omar Sandoval
2017-01-24 18:59                         ` Chris Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125225814.GA15621@vader \
    --to=osandov@osandov.com \
    --cc=agruenba@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=lists@colorremedies.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).