From: "Lakshmipathi.G" <lakshmipathi.g@giis.co.in>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: fsck-tests: verify 'btrfs check --repair' fixes corrupted nlink field
Date: Thu, 2 Feb 2017 09:46:06 +0530 [thread overview]
Message-ID: <20170202041606.GA3167@giis.co.in> (raw)
In-Reply-To: <dd4709b8-3d1d-6285-d5e5-c4f6962856e3@cn.fujitsu.com>
>
> apply anymore, but I'm expecting some more changes to it so please adapt
> it to the new file
Not sure what went wrong, will test the next patch with git apply and send it.
>
> I prefer 'inode_number' or simple 'ino' for the variable name.
>
Okay, will use inode_number.
> >+
> >+ $SUDO_HELPER $TOP/btrfs check $TEST_DEV &>> $RESULTS && \
> >+ _fail "btrfs check failed to detect nlink corruption"
> >+ run_check $SUDO_HELPER $TOP/btrfs check --repair $TEST_DEV
> >+ run_check $SUDO_HELPER $TOP/btrfs check $TEST_DEV
>
> What about using check_image() here?
I didn't know about check_image(), looks like above 3 lines can be replaced
with check_image. Will make the change.
>
> Thanks,
> Qu
>
Cheers.
Lakshmipathi.G
prev parent reply other threads:[~2017-02-02 4:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 10:47 [PATCH] btrfs-progs: fsck-tests: verify 'btrfs check --repair' fixes corrupted nlink field Lakshmipathi.G
[not found] ` <dd4709b8-3d1d-6285-d5e5-c4f6962856e3@cn.fujitsu.com>
2017-02-02 4:16 ` Lakshmipathi.G [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202041606.GA3167@giis.co.in \
--to=lakshmipathi.g@giis.co.in \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).