From: David Sterba <dsterba@suse.cz>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH] Btrfs: kill trans in run_delalloc_nocow and btrfs_cross_ref_exist
Date: Thu, 2 Feb 2017 19:18:37 +0100 [thread overview]
Message-ID: <20170202181837.GD16723@twin.jikos.cz> (raw)
In-Reply-To: <1485807928-17351-1-git-send-email-bo.li.liu@oracle.com>
On Mon, Jan 30, 2017 at 12:25:28PM -0800, Liu Bo wrote:
> run_delalloc_nocow has used trans in two places where they don't actually need
> @trans.
>
> For btrfs_lookup_file_extent, we search for file extents without COWing
> anything, and for btrfs_cross_ref_exist, the only place where we need @trans is
> deferencing it in order to get running_transaction which we could easily get
> from the global fs_info.
>
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Removing the transaction is ok, backed by some patch archeology.
prev parent reply other threads:[~2017-02-02 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 20:25 [PATCH] Btrfs: kill trans in run_delalloc_nocow and btrfs_cross_ref_exist Liu Bo
2017-02-02 18:18 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202181837.GD16723@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).