[PATCH] btrfs: remove unused ulist members

[PATCH] btrfs: remove unused ulist members

[David Sterba]

Commit "btrfs: ulist: Add ulist_del() function" (d4b804045924d7f8)
removed some debugging code but left the structure defintions.

Signed-off-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/ulist.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/fs/btrfs/ulist.h b/fs/btrfs/ulist.h
index a01a2c45825f..007b22fff3f9 100644
--- a/fs/btrfs/ulist.h
+++ b/fs/btrfs/ulist.h
@@ -19,9 +19,6 @@
  *
  */
 struct ulist_iterator {
-#ifdef CONFIG_BTRFS_DEBUG
-	int i;
-#endif
 	struct list_head *cur_list;  /* hint to start search */
 };
 
@@ -32,10 +29,6 @@ struct ulist_node {
 	u64 val;		/* value to store */
 	u64 aux;		/* auxiliary value saved along with the val */
 
-#ifdef CONFIG_BTRFS_DEBUG
-	int seqnum;		/* sequence number this node is added */
-#endif
-
 	struct list_head list;  /* used to link node */
 	struct rb_node rb_node;	/* used to speed up search */
 };
-- 
2.10.1

Re: [PATCH] btrfs: remove unused ulist members

[Qu Wenruo]

At 02/09/2017 11:47 PM, David Sterba wrote:
> Commit "btrfs: ulist: Add ulist_del() function" (d4b804045924d7f8)
> removed some debugging code but left the structure defintions.
>
> Signed-off-by: David Sterba <dsterba@suse.com>

Thanks for deleting that, I forgot to remove the member in structure.

Reviewed-by: Qu Wenruo <quwenruo@cn.fujitsu.com>

Thanks,
Qu
> ---
>  fs/btrfs/ulist.h | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/fs/btrfs/ulist.h b/fs/btrfs/ulist.h
> index a01a2c45825f..007b22fff3f9 100644
> --- a/fs/btrfs/ulist.h
> +++ b/fs/btrfs/ulist.h
> @@ -19,9 +19,6 @@
>   *
>   */
>  struct ulist_iterator {
> -#ifdef CONFIG_BTRFS_DEBUG
> -	int i;
> -#endif
>  	struct list_head *cur_list;  /* hint to start search */
>  };
>
> @@ -32,10 +29,6 @@ struct ulist_node {
>  	u64 val;		/* value to store */
>  	u64 aux;		/* auxiliary value saved along with the val */
>
> -#ifdef CONFIG_BTRFS_DEBUG
> -	int seqnum;		/* sequence number this node is added */
> -#endif
> -
>  	struct list_head list;  /* used to link node */
>  	struct rb_node rb_node;	/* used to speed up search */
>  };
>

Re: [PATCH] btrfs: remove unused ulist members

[Liu Bo]

On Thu, Feb 09, 2017 at 04:47:43PM +0100, David Sterba wrote:
> Commit "btrfs: ulist: Add ulist_del() function" (d4b804045924d7f8)
> removed some debugging code but left the structure defintions.
> 

Reviewed-by: Liu Bo <bo.li.liu@oracle.com>

> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
>  fs/btrfs/ulist.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/fs/btrfs/ulist.h b/fs/btrfs/ulist.h
> index a01a2c45825f..007b22fff3f9 100644
> --- a/fs/btrfs/ulist.h
> +++ b/fs/btrfs/ulist.h
> @@ -19,9 +19,6 @@
>   *
>   */
>  struct ulist_iterator {
> -#ifdef CONFIG_BTRFS_DEBUG
> -	int i;
> -#endif
>  	struct list_head *cur_list;  /* hint to start search */
>  };
>  
> @@ -32,10 +29,6 @@ struct ulist_node {
>  	u64 val;		/* value to store */
>  	u64 aux;		/* auxiliary value saved along with the val */
>  
> -#ifdef CONFIG_BTRFS_DEBUG
> -	int seqnum;		/* sequence number this node is added */
> -#endif
> -
>  	struct list_head list;  /* used to link node */
>  	struct rb_node rb_node;	/* used to speed up search */
>  };
> -- 
> 2.10.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html