From: Liu Bo <bo.li.liu@oracle.com>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: assertion failed: last_size == new_size, file: fs/btrfs/inode.c
Date: Mon, 27 Feb 2017 07:53:48 -0800 [thread overview]
Message-ID: <20170227155348.GB13488@lim.localdomain> (raw)
In-Reply-To: <20170227001842.dhrmaw3t3k4hkuii@codemonkey.org.uk>
On Sun, Feb 26, 2017 at 07:18:42PM -0500, Dave Jones wrote:
> Hitting this fairly frequently.. I'm not sure if this is the same bug I've
> been hitting occasionally since 4.9. The assertion looks new to me at least.
>
It was recently introduced by my commit and used to catch data loss at truncate.
Were you running the test with a mkfs.btrfs -O NO_HOLES?
(We just queued a fix for the NO_HOLES case in btrfs-next.)
Thanks,
-liubo
> Dave
>
> assertion failed: last_size == new_size, file: fs/btrfs/inode.c, line: 4619
> ------------[ cut here ]------------
> kernel BUG at fs/btrfs/ctree.h:3422!
> invalid opcode: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC
> CPU: 3 PID: 15655 Comm: trinity-c25 Not tainted 4.10.0-think+ #9
> task: ffff8804fb128040 task.stack: ffffc90008534000
> RIP: 0010:assfail.constprop.74+0x1c/0x1e [btrfs]
> RSP: 0018:ffffc90008537c58 EFLAGS: 00010282
> RAX: 000000000000004b RBX: 0000000000001000 RCX: 0000000000000001
> RDX: 0000000000000000 RSI: ffffffff81cb4173 RDI: 00000000ffffffff
> RBP: ffffc90008537c58 R08: 0000000000000000 R09: 0000000000000001
> R10: 0000000000000000 R11: 0000000000000000 R12: ffff8804fe821348
> R13: ffff88047eb5bb88 R14: ffff8804fe821348 R15: 0000000000000005
> FS: 00007f99b77a6b40(0000) GS:ffff880507e00000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00007f99b77a9010 CR3: 000000048c4bf000 CR4: 00000000001406e0
> Call Trace:
> btrfs_truncate_inode_items+0xbee/0x11e0 [btrfs]
> ? debug_smp_processor_id+0x17/0x20
> btrfs_truncate+0x102/0x2a0 [btrfs]
> btrfs_setattr+0x246/0x3b0 [btrfs]
> notify_change+0x256/0x440
> do_truncate+0x73/0xc0
> do_sys_ftruncate.constprop.19+0x111/0x170
> ? __this_cpu_preempt_check+0x13/0x20
> SyS_ftruncate+0xe/0x10
> do_syscall_64+0x66/0x1d0
> entry_SYSCALL64_slow_path+0x25/0x25
> RIP: 0033:0x7f99b70d00f9
> RSP: 002b:00007ffd992b7768 EFLAGS: 00000246
> ORIG_RAX: 000000000000004d
> RAX: ffffffffffffffda RBX: 000000000000004d RCX: 00007f99b70d00f9
> RDX: 0003680201d80849 RSI: 0000000000000d95 RDI: 0000000000000187
> RBP: 00007f99b76f0000 R08: 0000000000000001 R09: 0000000000000fd7
> R10: 0000000000000006 R11: 0000000000000246 R12: 0000000000000002
> R13: 00007f99b76f0048 R14: 00007f99b77a6ad8 R15: 00007f99b76f0000
> Code: 48 83 c4 18 5b 41 5c 41 5d 41 5e 41 5f 5d c3 55 89 f1 48 c7 c2 b1 f7 11 a0 48 89 fe 48 89 e5 48 c7 c7 f0 52 12 a0 e8 03 b7 0b e1 <0f> 0b 55 89 f1 48 c7 c2 a8 fa 11 a0 48 89 fe 48 89 e5 48 c7 c7
> RIP: assfail.constprop.74+0x1c/0x1e [btrfs] RSP: ffffc90008537c58
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-27 17:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 0:18 assertion failed: last_size == new_size, file: fs/btrfs/inode.c Dave Jones
2017-02-27 15:53 ` Liu Bo [this message]
2017-02-27 16:23 ` Dave Jones
2017-03-01 1:12 ` Liu Bo
2017-03-01 20:03 ` Dave Jones
2017-03-02 15:58 ` Liu Bo
2017-03-03 2:04 ` Liu Bo
2017-03-03 18:04 ` Dave Jones
2017-03-03 18:20 ` Liu Bo
2017-03-09 14:24 ` David Sterba
2017-03-09 17:26 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227155348.GB13488@lim.localdomain \
--to=bo.li.liu@oracle.com \
--cc=clm@fb.com \
--cc=davej@codemonkey.org.uk \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox