From: Liu Bo <bo.li.liu@oracle.com>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: assertion failed: last_size == new_size, file: fs/btrfs/inode.c
Date: Tue, 28 Feb 2017 17:12:01 -0800 [thread overview]
Message-ID: <20170301011201.GB9546@lim.localdomain> (raw)
In-Reply-To: <20170227162342.z6j4bvinnqppwjjm@codemonkey.org.uk>
On Mon, Feb 27, 2017 at 11:23:42AM -0500, Dave Jones wrote:
> On Mon, Feb 27, 2017 at 07:53:48AM -0800, Liu Bo wrote:
> > On Sun, Feb 26, 2017 at 07:18:42PM -0500, Dave Jones wrote:
> > > Hitting this fairly frequently.. I'm not sure if this is the same bug I've
> > > been hitting occasionally since 4.9. The assertion looks new to me at least.
> > >
> >
> > It was recently introduced by my commit and used to catch data loss at truncate.
> >
> > Were you running the test with a mkfs.btrfs -O NO_HOLES?
> > (We just queued a fix for the NO_HOLES case in btrfs-next.)
>
> No, a fs created with default mkfs.btrfs options.
I have this patch[1] to fix a bug which results in file hole extent, and this
bug could lead us to hit the assertion.
Would you try to run the test w/ it, please?
[1]: https://patchwork.kernel.org/patch/9597281/
Thanks,
-liubo
next prev parent reply other threads:[~2017-03-01 1:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 0:18 assertion failed: last_size == new_size, file: fs/btrfs/inode.c Dave Jones
2017-02-27 15:53 ` Liu Bo
2017-02-27 16:23 ` Dave Jones
2017-03-01 1:12 ` Liu Bo [this message]
2017-03-01 20:03 ` Dave Jones
2017-03-02 15:58 ` Liu Bo
2017-03-03 2:04 ` Liu Bo
2017-03-03 18:04 ` Dave Jones
2017-03-03 18:20 ` Liu Bo
2017-03-09 14:24 ` David Sterba
2017-03-09 17:26 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301011201.GB9546@lim.localdomain \
--to=bo.li.liu@oracle.com \
--cc=clm@fb.com \
--cc=davej@codemonkey.org.uk \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).