From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:39048 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971AbdCBXDS (ORCPT ); Thu, 2 Mar 2017 18:03:18 -0500 Date: Thu, 2 Mar 2017 19:59:46 +0100 From: David Sterba To: "Dmitry V. Levin" Cc: Chris Mason , Josef Bacik , Jeff Mahoney , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] btrfs: remove btrfs_err_str function from uapi/linux/btrfs.h Message-ID: <20170302185946.GL4662@suse.cz> Reply-To: dsterba@suse.cz References: <20170215200259.GA1028@altlinux.org> <20170215225503.GA2947@altlinux.org> <20170228231250.GA10156@altlinux.org> <20170301145434.GD4662@twin.jikos.cz> <20170302114212.GK4662@suse.cz> <20170302130117.GA2208@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170302130117.GA2208@altlinux.org> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Thu, Mar 02, 2017 at 04:01:17PM +0300, Dmitry V. Levin wrote: > On Thu, Mar 02, 2017 at 12:42:12PM +0100, David Sterba wrote: > > On Wed, Mar 01, 2017 at 03:54:35PM +0100, David Sterba wrote: > > > On Wed, Mar 01, 2017 at 02:12:50AM +0300, Dmitry V. Levin wrote: > > > > btrfs_err_str function is not called from anywhere and is replicated > > > > in the userspace headers for btrfs-progs. > > > > > > > > It's removal also fixes the following linux/btrfs.h userspace > > > > compilation error: > > > > > > > > /usr/include/linux/btrfs.h: In function 'btrfs_err_str': > > > > /usr/include/linux/btrfs.h:740:11: error: 'NULL' undeclared (first use in this function) > > > > return NULL; > > > > > > > > Suggested-by: Jeff Mahoney > > > > Signed-off-by: Dmitry V. Levin > > > > Reviewed-by: David Sterba > > > > --- > > > > v3: the patch seems to be lost, resending with updated list of addressees > > > > > > Indeed, I can't find how or where it got lost, sorry. Added to 4.11 > > > again. > > > > So it's because you did not CC linux-btrfs@ , I have the mails in my > > inbox but haven't found it in the other folder while picking patches. > > Thanks, I though so when Cc'ed linux-btrfs@ the last time. > > Consider updating MAINTAINERS file so that scripts/get_maintainer.pl > would be able to print the right addressees for btrfs header files: Good idea. > diff --git a/MAINTAINERS b/MAINTAINERS > index 0001835..04a758f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2905,4 +2905,6 @@ S: Maintained > F: Documentation/filesystems/btrfs.txt > F: fs/btrfs/ > +F: include/linux/btrfs* > +F: include/uapi/linux/btrfs* > > BTTV VIDEO4LINUX DRIVER Please send a proper patch and add Acked-by: David Sterba