From: Liu Bo <bo.li.liu@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: add file item tracepoint
Date: Tue, 7 Mar 2017 08:49:42 -0800 [thread overview]
Message-ID: <20170307164942.GA13162@localhost.localdomain> (raw)
In-Reply-To: <20170307154824.GV4662@twin.jikos.cz>
On Tue, Mar 07, 2017 at 04:48:24PM +0100, David Sterba wrote:
> On Fri, Mar 03, 2017 at 06:41:27PM -0800, Liu Bo wrote:
> > + TP_printk_btrfs(
> > + "root %llu(%s) ino %llu sz 0x%llx disk_isz 0x%llx "
> > + "file extent range [0x%llx 0x%llx] "
> > + "(num_bytes 0x%llx ram_bytes 0x%llx disk_bytenr 0x%llx "
> > + "disk_num_bytes 0x%llx extent_offset 0x%llx type (%s) "
> > + "compression %u",
>
> > + TP_printk_btrfs(
> > + "root %llu(%s) ino %llu sz 0x%llx disk_isz 0x%llx "
> > + "file extent range [0x%llx 0x%llx] "
> > + "extent_type (%s) compression %u",
>
> Please update the message formats according to
> https://btrfs.wiki.kernel.org/index.php/Development_notes#Tracepoints
I feel like for size and offset, if using '%llu' rather than '%llx', it
is not easy to tell whether the size/offset is aligned to 4K or not.
Thanks,
-liubo
next prev parent reply other threads:[~2017-03-07 19:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 2:41 [PATCH] Btrfs: add file item tracepoint Liu Bo
2017-03-07 15:48 ` David Sterba
2017-03-07 16:49 ` Liu Bo [this message]
2017-03-09 12:52 ` David Sterba
2017-03-09 18:36 ` Liu Bo
2017-03-10 19:09 ` [PATCH v2] " Liu Bo
2017-03-14 12:42 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307164942.GA13162@localhost.localdomain \
--to=bo.li.liu@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).