Re: Btrfs progs pre-release 4.10-rc1

[David Sterba <dsterba@suse.cz>]

On Wed, Mar 08, 2017 at 09:11:37AM +0900, Tsutomu Itoh wrote:
> >>>
> >>> Benedikt Morbach (1):
> >>>       btrfs-progs: send-dump: add missing newlines
> >>>
> >>> David Sterba (102):
> >>
> >>>       btrfs-progs: rework option parser to use getopt for global options
> >>
> >> I think that btrfs/{008,016,019,...} of xfstests has failed due to the
> >> above patch.
> >>
> >> btrfs/008 1s ... [failed, exit status 1] - output mismatch (see /xfstests/results//btrfs/008.out.bad)
> >>     --- tests/btrfs/008.out     2015-08-04 16:09:38.000000000 +0900
> >>     +++ /xfstests/results//btrfs/008.out.bad    2017-03-07 09:00:50.581906234 +0900
> >>     @@ -1,2 +1,3 @@
> >>      QA output created by 008
> >>     -Silence is golden
> >>     +send failed
> >>     +(see /xfstests/results//btrfs/008.full for details)
> > 
> > What's in the .full report?
> 
> $ cat 008.full
> Create subvolume '/test5/send_temp_008/send'
> Create a readonly snapshot of '/test5/send_temp_008/send' in '/test5/send_temp_008/send/snapshots/backup2'
> Create a readonly snapshot of '/test5/send_temp_008/send' in '/test5/send_temp_008/send/snapshots/backup3'
> ERROR: unable to resolve -f
> send failed

So it's because the newly added global options make option parsing more
strict and the fstests do not follow the order where options come first:

eg. from 008:

 80 $BTRFS_UTIL_PROG send $work_dir/snapshots/backup3/ -f $TEST_DIR/$tmp_dir/blah \
 81         >> $seqres.full 2>&1 || _fail "send failed"

ie "$work_dir/snapshots/backup3/" is non-option argument but "-f" is an
option. This is normally accepted by getopt as it reorders the arguments
so that options are always first.

I will delay the patch so that the fstests won't fail but this needs to
be fixed soon as the newly added global options are building block for
other enhancements.