From: David Sterba <dsterba@suse.cz>
To: "Holger Hoffstätte" <holger@applied-asynchrony.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: Question re. <linux/sizes.h> required since btrfs-progs-4.10
Date: Mon, 13 Mar 2017 16:05:59 +0100 [thread overview]
Message-ID: <20170313150559.GL14605@twin.jikos.cz> (raw)
In-Reply-To: <58C42024.6000401@applied-asynchrony.com>
On Sat, Mar 11, 2017 at 05:04:52PM +0100, Holger Hoffstätte wrote:
> I'm on Gentoo and wanted to update Docker to 17.03.0, which failed when it
> couldn't build the btrfs driver due to a missing <linux/sizes.h>.
> This worked fine on another machine the other day, so I dug in and found that
> the only difference was an intermediate update to btrfs-progs 4.10.
> Sure enough: since 4.10 ctree.h includes <linux/sizes.h>, which is nowhere
> to be found in my package of linux-headers-4.10 (also not in 4.9).
>
> Simply copying sizes.h from the 4.9 kernel sources made everything work,
> but I'm curious whether this is actually correct - hence my question whether
> <linux/sizes.h> _should_ actually be installed? Is this a bug with
> Gentoo's kernel header package or a new problem with btrfs-progs?
That's a bug in btrfs-progs, the build tests do not cover that. There's
a local copy of sizes.h that's supposed to be used. The patch was ported
from kernel where linus/sizes.h is present but is probably not (yet)
part of the public linux-headers.
> I don't see any good reason why sizes.h should not be installed, but wanted
> to verify since there are probably users of other distributions here as
> well. :)
The build would fail on any distro. I'll commit a fix and update the
tests so this gets caught early. Thanks for the report.
prev parent reply other threads:[~2017-03-13 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 16:04 Question re. <linux/sizes.h> required since btrfs-progs-4.10 Holger Hoffstätte
2017-03-13 15:05 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313150559.GL14605@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=holger@applied-asynchrony.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox