From: David Sterba <dsterba@suse.cz>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH v2] Btrfs: set scrub page's io_error if failing to submit io
Date: Wed, 29 Mar 2017 22:55:57 +0200 [thread overview]
Message-ID: <20170329205557.GE4781@twin.jikos.cz> (raw)
In-Reply-To: <1490810116-19216-1-git-send-email-bo.li.liu@oracle.com>
On Wed, Mar 29, 2017 at 10:55:16AM -0700, Liu Bo wrote:
> Scrub repairs data by the unit called scrub_block, which may contains
> several pages. Scrub always tries to look up a good copy of a whole
> block, but if there's no such copy, it tries to do repair page by page.
>
> If we don't set page's io_error when checking this bad copy, in the last
> step, we may skip this page when repairing bad copy from good copy.
Great, thanks.
> Cc: David Sterba <dsterba@suse.cz>
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2017-03-29 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 23:48 [PATCH] Btrfs: set scrub page's io_error if failing to submit io Liu Bo
2017-03-27 17:12 ` David Sterba
2017-03-29 17:55 ` [PATCH v2] " Liu Bo
2017-03-29 20:55 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329205557.GE4781@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).