From: Adam Borowski <kilobyte@angband.pl>
To: David Sterba <dsterba@suse.com>, Chris Mason <clm@fb.com>,
Josef Bacik <jbacik@fb.com>,
linux-btrfs@vger.kernel.org
Cc: Adam Borowski <kilobyte@angband.pl>
Subject: [PATCH] btrfs: drop the nossd flag when remounting with -o ssd
Date: Fri, 31 Mar 2017 17:19:04 +0200 [thread overview]
Message-ID: <20170331151904.4091-1-kilobyte@angband.pl> (raw)
In-Reply-To: <0939c5df-3abd-ec68-16ef-538ad04251aa@mendix.com>
The opposite case was already handled right in the very next switch entry.
Reported-by: Hans van Kranenburg <hans.van.kranenburg@mendix.com>
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
Not sure if setting NOSSD should also disable SSD_SPREAD, there's currently
no way to disable that option once set.
fs/btrfs/super.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 06bd9b332e18..7342399951ad 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -549,11 +549,13 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options,
case Opt_ssd:
btrfs_set_and_info(info, SSD,
"use ssd allocation scheme");
+ btrfs_clear_opt(info->mount_opt, NOSSD);
break;
case Opt_ssd_spread:
btrfs_set_and_info(info, SSD_SPREAD,
"use spread ssd allocation scheme");
btrfs_set_opt(info->mount_opt, SSD);
+ btrfs_clear_opt(info->mount_opt, NOSSD);
break;
case Opt_nossd:
btrfs_set_and_info(info, NOSSD,
--
2.11.0
next prev parent reply other threads:[~2017-03-31 15:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 23:01 Cosmetics bug: remounting ssd does not clear nossd Hans van Kranenburg
2017-03-31 15:19 ` Adam Borowski [this message]
2017-03-31 16:00 ` [PATCH] btrfs: drop the nossd flag when remounting with -o ssd Hans van Kranenburg
2017-03-31 17:10 ` David Sterba
2017-03-31 20:08 ` [PATCH v2] " Adam Borowski
2017-03-31 20:24 ` Hans van Kranenburg
2017-03-31 20:43 ` Adam Borowski
2017-03-31 20:50 ` Hans van Kranenburg
2017-04-03 12:24 ` David Sterba
2017-04-03 22:43 ` Hans van Kranenburg
2017-04-10 17:35 ` David Sterba
2017-04-03 12:25 ` David Sterba
2017-04-15 19:12 ` [PATCH] " Hans van Kranenburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331151904.4091-1-kilobyte@angband.pl \
--to=kilobyte@angband.pl \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).