From: "Theodore Ts'o" <tytso@mit.edu>
To: Eryu Guan <eguan@redhat.com>
Cc: Qu Wenruo <quwenruo@cn.fujitsu.com>,
linux-btrfs@vger.kernel.org, fstests@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] fstests: generic: Check if cycle mount and sleep can affect fiemap result
Date: Thu, 6 Apr 2017 12:26:16 -0400 [thread overview]
Message-ID: <20170406162616.zsnbgx6vy2fgugmq@thunk.org> (raw)
In-Reply-To: <20170405023526.GS22845@eguan.usersys.redhat.com>
On Wed, Apr 05, 2017 at 10:35:26AM +0800, Eryu Guan wrote:
>
> Test fails with ext3/2 when driving with ext4 driver, fiemap changed
> after umount/mount cycle, then changed back to original result after
> sleeping some time. An ext4 bug? (cc'ed linux-ext4 list.)
I haven't had time to look at this, but I'm not sure this test is a
reasonable one on the face of it.
A file system may choose to optimize a file's extent tree for whatever
reason it wants, whenever it wants, including on an unmount --- and
that would not be an invalid thing to do. So to have an xfstests that
causes a test failure if a file system were to, say, do some cleanup
at mount or unmount time, or when the file is next opened, to merge
adjacent extents together (and hence change what is returned by
FIEMAP) might be strange, or even weird --- but is this any of user
space's business? Or anything we want to enforce as wrong wrong wrong
by xfstests?
- Ted
next prev parent reply other threads:[~2017-04-06 16:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 7:09 [PATCH] fstests: generic: Check if cycle mount and sleep can affect fiemap result Qu Wenruo
2017-04-03 16:31 ` Darrick J. Wong
2017-04-05 0:51 ` Qu Wenruo
2017-04-05 2:35 ` Eryu Guan
2017-04-05 2:42 ` Qu Wenruo
2017-04-06 16:26 ` Theodore Ts'o [this message]
2017-04-06 16:28 ` Eric Sandeen
2017-04-07 0:48 ` Qu Wenruo
2017-04-07 5:02 ` Eryu Guan
2017-04-07 15:42 ` Darrick J. Wong
2017-04-07 15:48 ` Eric Sandeen
2017-04-10 2:07 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406162616.zsnbgx6vy2fgugmq@thunk.org \
--to=tytso@mit.edu \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).