From: Christoph Hellwig <hch@infradead.org>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: linux-fsdevel@vger.kernel.org, jack@suse.com, hch@infradead.org,
linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
sagi@grimberg.me, avi@scylladb.com, axboe@kernel.dk,
linux-api@vger.kernel.org, willy@infradead.org,
tom.leiming@gmail.com, Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH 1/9] Use RWF_* flags for AIO operations
Date: Wed, 12 Apr 2017 01:33:08 -0700 [thread overview]
Message-ID: <20170412083308.GA22363@infradead.org> (raw)
In-Reply-To: <20170411142619.27205-2-rgoldwyn@suse.de>
>
> + if (unlikely(iocb->aio_rw_flags & ~(RWF_HIPRI | RWF_DSYNC | RWF_SYNC))) {
> + pr_debug("EINVAL: aio_rw_flags set with incompatible flags\n");
> + return -EINVAL;
> + }
> + if (iocb->aio_rw_flags & RWF_HIPRI)
> + req->common.ki_flags |= IOCB_HIPRI;
> + if (iocb->aio_rw_flags & RWF_DSYNC)
> + req->common.ki_flags |= IOCB_DSYNC;
> + if (iocb->aio_rw_flags & RWF_SYNC)
> + req->common.ki_flags |= (IOCB_DSYNC | IOCB_SYNC);
Pleae introduce a common helper to share this code between the
synchronous and the aio path
next prev parent reply other threads:[~2017-04-12 8:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 14:26 [PATCH 0/9 v5] No wait AIO Goldwyn Rodrigues
2017-04-11 14:26 ` [PATCH 1/9] Use RWF_* flags for AIO operations Goldwyn Rodrigues
2017-04-12 8:33 ` Christoph Hellwig [this message]
2017-04-11 14:26 ` [PATCH 2/9] nowait aio: Introduce RWF_NOWAIT Goldwyn Rodrigues
2017-04-11 14:26 ` [PATCH 3/9] nowait aio: return if direct write will trigger writeback Goldwyn Rodrigues
2017-04-11 14:26 ` [PATCH 4/9] nowait-aio: Introduce IOMAP_NOWAIT Goldwyn Rodrigues
2017-04-11 14:26 ` [PATCH 5/9] nowait aio: return on congested block device Goldwyn Rodrigues
2017-04-12 8:36 ` Christoph Hellwig
2017-04-12 18:31 ` Goldwyn Rodrigues
2017-04-11 14:26 ` [PATCH 6/9] nowait aio: ext4 Goldwyn Rodrigues
2017-04-11 14:26 ` [PATCH 7/9] nowait aio: xfs Goldwyn Rodrigues
2017-04-11 14:26 ` [PATCH 8/9] nowait aio: btrfs Goldwyn Rodrigues
2017-04-11 14:26 ` [PATCH 9/9] nowait aio: Return -EOPNOTSUPP if filesystem does not support Goldwyn Rodrigues
2017-04-12 8:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412083308.GA22363@infradead.org \
--to=hch@infradead.org \
--cc=avi@scylladb.com \
--cc=axboe@kernel.dk \
--cc=jack@suse.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
--cc=sagi@grimberg.me \
--cc=tom.leiming@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).