* [PATCH 1/1 linux-next] btrfs: kmap() can't fail
@ 2017-04-25 18:11 Fabian Frederick
2017-05-02 15:46 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2017-04-25 18:11 UTC (permalink / raw)
To: Chris Mason, David Sterba; +Cc: Josef Bacik, linux-btrfs, linux-kernel, fabf
Remove NULL test on kmap()
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/btrfs/check-integrity.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c
index ab14c2e..496eb00 100644
--- a/fs/btrfs/check-integrity.c
+++ b/fs/btrfs/check-integrity.c
@@ -1668,14 +1668,8 @@ static int btrfsic_read_block(struct btrfsic_state *state,
dev_bytenr += (j - i) * PAGE_SIZE;
i = j;
}
- for (i = 0; i < num_pages; i++) {
+ for (i = 0; i < num_pages; i++)
block_ctx->datav[i] = kmap(block_ctx->pagev[i]);
- if (!block_ctx->datav[i]) {
- pr_info("btrfsic: kmap() failed (dev %s)!\n",
- block_ctx->dev->name);
- return -1;
- }
- }
return block_ctx->len;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1 linux-next] btrfs: kmap() can't fail
2017-04-25 18:11 [PATCH 1/1 linux-next] btrfs: kmap() can't fail Fabian Frederick
@ 2017-05-02 15:46 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2017-05-02 15:46 UTC (permalink / raw)
To: Fabian Frederick
Cc: Chris Mason, David Sterba, Josef Bacik, linux-btrfs, linux-kernel
On Tue, Apr 25, 2017 at 08:11:02PM +0200, Fabian Frederick wrote:
> Remove NULL test on kmap()
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Reviewed-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-02 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-25 18:11 [PATCH 1/1 linux-next] btrfs: kmap() can't fail Fabian Frederick
2017-05-02 15:46 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).