linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adam Borowski <kilobyte@angband.pl>
To: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
	David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH ping] btrfs: warn about RAID5/6 being experimental at mount time
Date: Wed, 26 Apr 2017 04:14:16 +0200	[thread overview]
Message-ID: <20170426021416.us4zj2blho26sjgc@angband.pl> (raw)
In-Reply-To: <20170419210745.15263-1-kilobyte@angband.pl>

On Wed, Apr 19, 2017 at 11:07:45PM +0200, Adam Borowski wrote:
> Too many people come complaining about losing their data -- and indeed,
> there's no warning outside a wiki and the mailing list tribal knowledge.
> Message severity chosen for consistency with XFS -- "alert" makes dmesg
> produce nice red background which should get the point across.
...
> I intend to ask for inclusion of this one (or an equivalent) in 4.9, either
> in Debian or via GregKH -- while for us kernels "that old" are history,
> regular users expect stable releases to be free of known serious data loss
> bugs.

Hi guys, could you please comment?  While there's only relatively little
urgency for mainline (heck, it'd be best if the warning was not needed at
all!), there's a Debian release close by, and it's be grossly inresponsible
to not let people know that a feature advertised in the documentation is in
an unusable state (especially as of 4.9).  For you, filesystem developers,
a way of thinking that "the user should do research" might be acceptable,
but once it filters down to a stable release, the user expects no known
serious bugs.

And here the severity is "critical -- causes serious data loss".

> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index e54844767fe5..e7f91f70e149 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -3083,6 +3083,14 @@ int open_ctree(struct super_block *sb,
>  		btrfs_set_opt(fs_info->mount_opt, SSD);
>  	}
>  
> +	if ((fs_info->avail_data_alloc_bits |
> +	     fs_info->avail_metadata_alloc_bits |
> +	     fs_info->avail_system_alloc_bits) &
> +	    BTRFS_BLOCK_GROUP_RAID56_MASK) {
> +		btrfs_alert(fs_info,
> +		"btrfs RAID5/6 is EXPERIMENTAL and has known data-loss bugs");
> +	}
> +
>  	/*
>  	 * Mount does not set all options immediately, we can do it now and do
>  	 * not have to wait for transaction commit
> -- 

Doing this in the kernel should be better than in userspace (like
https://patchwork.kernel.org/patch/9450035/) as it can deal with a future
kernel with working RAID5/6 on old -progs; but if you prefer, I can finish
that patch and request its inclusion in Debian stretch -progs instead or in
addition to the above warning in the kernel.

ᛗᛖᛟᚹ!
-- 
⢀⣴⠾⠻⢶⣦⠀ Meow!
⣾⠁⢠⠒⠀⣿⡁
⢿⡄⠘⠷⠚⠋⠀ Collisions shmolisions, let's see them find a collision or second
⠈⠳⣄⠀⠀⠀⠀ preimage for double rot13!

  parent reply	other threads:[~2017-04-26  2:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 21:07 [PATCH ping] btrfs: warn about RAID5/6 being experimental at mount time Adam Borowski
2017-04-20 20:13 ` Duncan
2017-04-20 20:16   ` Sargun Dhillon
2017-04-26  2:14 ` Adam Borowski [this message]
2017-05-05 19:45   ` David Sterba
2017-05-09  1:49     ` Adam Borowski
2017-05-09 19:34       ` Goffredo Baroncelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426021416.us4zj2blho26sjgc@angband.pl \
    --to=kilobyte@angband.pl \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).