From: Liu Bo <bo.li.liu@oracle.com>
To: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 06/10] btrfs: scrub: use bool for flush_all_writes
Date: Thu, 18 May 2017 17:42:24 -0700 [thread overview]
Message-ID: <20170519004224.GK23822@lim.localdomain> (raw)
In-Reply-To: <0d4dcd2dd113cdff9141336e583ab5afacfeee6f.1494954480.git.dsterba@suse.com>
On Tue, May 16, 2017 at 07:10:38PM +0200, David Sterba wrote:
> flush_all_writes is an atomic but does not use the semantics at all,
> it's just on/off indicator, we can use bool.
>
It might use atomic to avoid reordering, but I'm not sure if
reordering could really happen here.
Thanks,
-liubo
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
> fs/btrfs/scrub.c | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
> index 2c1d344c8edd..8caf775fee0a 100644
> --- a/fs/btrfs/scrub.c
> +++ b/fs/btrfs/scrub.c
> @@ -182,8 +182,8 @@ struct scrub_ctx {
>
> struct scrub_bio *wr_curr_bio;
> struct mutex wr_lock;
> - atomic_t flush_all_writes;
> struct btrfs_device *wr_tgtdev;
> + bool flush_all_writes;
>
> /*
> * statistics
> @@ -718,7 +718,7 @@ struct scrub_ctx *scrub_setup_ctx(struct btrfs_device *dev, int is_dev_replace)
> if (is_dev_replace) {
> WARN_ON(!dev->bdev);
> sctx->wr_tgtdev = dev;
> - atomic_set(&sctx->flush_all_writes, 0);
> + sctx->flush_all_writes = false;
> }
>
> return sctx;
> @@ -2410,8 +2410,7 @@ static void scrub_missing_raid56_worker(struct btrfs_work *work)
>
> scrub_block_put(sblock);
>
> - if (sctx->is_dev_replace &&
> - atomic_read(&sctx->flush_all_writes)) {
> + if (sctx->is_dev_replace && sctx->flush_all_writes) {
> mutex_lock(&sctx->wr_lock);
> scrub_wr_submit(sctx);
> mutex_unlock(&sctx->wr_lock);
> @@ -2618,8 +2617,7 @@ static void scrub_bio_end_io_worker(struct btrfs_work *work)
> sctx->first_free = sbio->index;
> spin_unlock(&sctx->list_lock);
>
> - if (sctx->is_dev_replace &&
> - atomic_read(&sctx->flush_all_writes)) {
> + if (sctx->is_dev_replace && sctx->flush_all_writes) {
> mutex_lock(&sctx->wr_lock);
> scrub_wr_submit(sctx);
> mutex_unlock(&sctx->wr_lock);
> @@ -3454,14 +3452,14 @@ static noinline_for_stack int scrub_stripe(struct scrub_ctx *sctx,
> */
> if (atomic_read(&fs_info->scrub_pause_req)) {
> /* push queued extents */
> - atomic_set(&sctx->flush_all_writes, 1);
> + sctx->flush_all_writes = true;
> scrub_submit(sctx);
> mutex_lock(&sctx->wr_lock);
> scrub_wr_submit(sctx);
> mutex_unlock(&sctx->wr_lock);
> wait_event(sctx->list_wait,
> atomic_read(&sctx->bios_in_flight) == 0);
> - atomic_set(&sctx->flush_all_writes, 0);
> + sctx->flush_all_writes = false;
> scrub_blocked_if_needed(fs_info);
> }
>
> @@ -3907,7 +3905,7 @@ int scrub_enumerate_chunks(struct scrub_ctx *sctx,
> * write requests are really completed when bios_in_flight
> * changes to 0.
> */
> - atomic_set(&sctx->flush_all_writes, 1);
> + sctx->flush_all_writes = true;
> scrub_submit(sctx);
> mutex_lock(&sctx->wr_lock);
> scrub_wr_submit(sctx);
> @@ -3925,7 +3923,7 @@ int scrub_enumerate_chunks(struct scrub_ctx *sctx,
> */
> wait_event(sctx->list_wait,
> atomic_read(&sctx->workers_pending) == 0);
> - atomic_set(&sctx->flush_all_writes, 0);
> + sctx->flush_all_writes = false;
>
> scrub_pause_off(fs_info);
>
> --
> 2.12.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-05-19 0:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 17:10 [PATCH 00/10] Btrfs, minor scrub code cleanups David Sterba
2017-05-16 17:10 ` [PATCH 01/10] btrfs: scrub: inline helper scrub_setup_wr_ctx David Sterba
2017-05-16 17:10 ` [PATCH 02/10] btrfs: scrub: inline helper scrub_free_wr_ctx David Sterba
2017-05-16 17:10 ` [PATCH 03/10] btrfs: scrub: simplify cleanup of wr_ctx in scrub_free_ctx David Sterba
2017-05-19 0:25 ` Liu Bo
2017-05-16 17:10 ` [PATCH 04/10] btrfs: scrub: embed scrub_wr_ctx into scrub context David Sterba
2017-05-16 17:10 ` [PATCH 05/10] btrfs: scrub: remove pages_per_wr_bio from " David Sterba
2017-05-16 17:10 ` [PATCH 06/10] btrfs: scrub: use bool for flush_all_writes David Sterba
2017-05-19 0:42 ` Liu Bo [this message]
2017-05-19 13:08 ` David Sterba
2017-05-29 14:59 ` David Sterba
2017-05-16 17:10 ` [PATCH 07/10] btrfs: scrub: use fs_info::sectorsize and drop it from scrub context David Sterba
2017-05-19 0:43 ` Liu Bo
2017-05-16 17:10 ` [PATCH 08/10] btrfs: scrub: clean up division in __scrub_mark_bitmap David Sterba
2017-05-16 17:10 ` [PATCH 09/10] btrfs: scrub: clean up division in scrub_find_csum David Sterba
2017-05-16 17:10 ` [PATCH 10/10] btrfs: scrub: simplify srrub worker initialization David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519004224.GK23822@lim.localdomain \
--to=bo.li.liu@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).