From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz, jeffm@suse.com
Subject: Re: [RFC PATCH] btrfs: Clean up btrfs_leaf_data
Date: Fri, 19 May 2017 19:52:22 +0200 [thread overview]
Message-ID: <20170519175222.GY4065@twin.jikos.cz> (raw)
In-Reply-To: <1495180150-12069-1-git-send-email-nborisov@suse.com>
On Fri, May 19, 2017 at 10:49:10AM +0300, Nikolay Borisov wrote:
> Commit 5f39d397dfbe ("Btrfs: Create extent_buffer interface for large blocksizes")
> refactored btrfs_leaf_data function to take extent_buffer rather than
> struct btrfs_leaf. However, as it turns out the parameter being passed is never
> used. Help the brave souls which are going to read this code in the future
> by eliminating the parameter.
The git changelog lines should be at most 74 chars.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
>
> Hello,
>
> Here is a minor cleanup, which hopefully reduces cognitive load while reading
> the extent_buffer code. After this commit btrfs_leaf_data basically becomes
> a synonym to offsetof and I can't help it but begin to wonder wouldn't it be
> better if I nuke btrfs_leaf_data altogether or rename it to
> btrfs_leaf_data_offset?
Yes please, make it BTRFS_LEAF_DATA_OFFSET so it's consistent with other
BTRFS_LEAF_* helpers.
prev parent reply other threads:[~2017-05-19 17:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 7:49 [RFC PATCH] btrfs: Clean up btrfs_leaf_data Nikolay Borisov
2017-05-19 17:52 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519175222.GY4065@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox