From: Christoph Hellwig <hch@infradead.org>
To: Anand Jain <anand.jain@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org,
dsterba@suse.cz
Subject: Re: [PATCH 1/2] block: Introduce blkdev_issue_flush_no_wait()
Date: Sun, 21 May 2017 00:09:45 -0700 [thread overview]
Message-ID: <20170521070945.GC10453@infradead.org> (raw)
In-Reply-To: <d97acfdb-3ab1-5722-f341-a8feba1a72ef@oracle.com>
On Thu, May 18, 2017 at 05:31:32PM +0800, Anand Jain wrote:
> You mean at btrfs: write_dev_flush()
> OR
> block: blkdev_issue_flush() ?
> Where I find
> q = bdev_get_queue(bdev);
> if (!q)
> return -ENXIO
> isn't needed as anyway generic_make_request_checks() will
> check that down below.
> Not too sure about the other two checks though.
I was looking at your new function, but indeed it seems like the
function is mostly copy & pasted from blkdev_issue_flush.
The bdev->bd_disk, !bdev_get_queue and q->make_request_fn checks
are all things you don't need, any blkdev_issue_flush should not
either, although I'll need to look into the weird loop workaround
again, which doesn't make much sense to me.
next prev parent reply other threads:[~2017-05-21 7:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 9:39 [RFC PATCH 0/2] Introduce blkdev_issue_flush_no_wait() Anand Jain
2017-05-16 9:39 ` [PATCH 1/2] block: " Anand Jain
2017-05-16 11:56 ` Christoph Hellwig
2017-05-18 9:31 ` Anand Jain
2017-05-21 7:09 ` Christoph Hellwig [this message]
2017-05-24 8:42 ` Anand Jain
2017-05-16 9:39 ` [PATCH 2/2] btrfs: Use blkdev_issue_flush_no_wait() Anand Jain
2017-05-16 12:00 ` Christoph Hellwig
2017-05-16 14:07 ` [RFC PATCH 0/2] Introduce blkdev_issue_flush_no_wait() Bart Van Assche
2017-05-17 17:14 ` David Sterba
2017-05-18 9:31 ` Anand Jain
2017-05-18 9:27 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521070945.GC10453@infradead.org \
--to=hch@infradead.org \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).